-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new -today-in-history
, -month
, -day
, and -year
search filters
#1145
Conversation
c2c0c3f
to
0355af9
Compare
There is some accidental functionality overlap with |
Edit: I ended up using the built-in |
776bb80
to
748fc5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a promising start.
I put a few comments inline. Once those, and the questions in the issue are resolved, I think we can move this one forward.
Thank you!
5cc3249
to
b833d50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thank you!
We're just waiting on nailing down the name for the reminisce arg, and then we can get this merged in.
I've updated the name. I think this is complete now. |
@KarimPwnz Thank you! I started a new dayjob last week and it's taking up all my time during the week right now. I'll get through every review and issue reply on Saturday. Thanks for your patience! |
Oh, congrats on the job! Do take your time. |
-today-in-history
, -month
, -day
, and -year
search filters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you!
I have implemented
-month
,-day
, and-year
for more general searching (values are parsed throughtime.parse
). Additionally, this PR includes-reminisce
which shows entries from today over the years, by modifying-month
and-day
(this resolves #1143).However, I did not implement the
(_ years ago)
output suggested in #1143: it would add too much complexity.Also, the included tests check-reminisce
implicitly through-month
and-day
: I did not find a way to elegantly create journals exactly a year ago.Edit: I have implemented
-reminisce
tests—see comments below.Checklist
for the same issue.