-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom extensions when editing (for easier syntax highlighting) #1139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic. Thank you!
Has anyone written a custom syntax highlighting package for vim / neovim for .jrnl files? Is this in the works? |
@alichtman I have a modified markdown sytnax that I use in my personal dotfiles for jrnl (see here). But there's not a proper package that I know of. We're not currently planning one, but would be happy to accept PRs and/or link to a package in the docs. |
Ever considered making your syntax file a vim plugin? Basically just drop it in a separate repo, and make it importable through plug-in managers. I'd use it. |
The reason I've put off making it a plugin is because the implementation is brittle, and tailored to my personal preferences. I keep telling myself that I'll clean it up and making a plugin, but haven't made it a priority. But I think this might be an instance of the perfect being an enemy of the good(ish) enough. If I make it a plugin now, then users would likely file issues and PRs that would help improve it for everyone. So, why not, I guess. I haven't made a vim plugin before, but I'll give it a shot with this. Thanks for prompting me about it! |
With this PR, the temporary filename's suffix will either be its template filename or ".jrnl". This allows custom extensions and formalizes the ".jrnl" extension for "better text editor integration." I have also created the necessary tests.
This closes #1059 and closes #1080.
Checklist
for the same issue.