-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify user when config directory can't be created because there is already a file with the same name #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-- everything is broken right now
…still broken though
…t wasn't using it
# Conflicts: # CHANGELOG.md
wren
reviewed
Jan 1, 2021
wren
reviewed
Jan 1, 2021
wren
approved these changes
Jan 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤠
wren
changed the title
Notify user when XDG configuration directory can't be made because there is already a file with the same name
Notify user when config directory can't be created because there is already a file with the same name
Jan 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #659. It catches an exception in the XDG method and lets the user know exactly where the problem is.
While working on this, I noticed that a ton of configuration code was in the install.py file, so I moved it to config.py as necessary and updated the tests to use patches instead of a global. The configuration code still needs a lot of work but I hope this is at least a step in the right direction.
I couldn't come up with a good strategy to automatically test this issue, since XDG is essentially global to the program. Here's my manual test:
Checklist
for the same issue.