Update Terraform repl package to bring in better formatting #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repl package in Terraform core was updated to include heredoc formatting
for multiline strings. The interface for this package changed to use cty.Value
rather than map[string]interface{} so I had to bring in cty as a dependency
and update the code that munges the manifest after it has been decoded to use it.
alexsomesan
approved these changes
Mar 18, 2021
| var serverSideMetadataFields = []string{ | ||
| // ignoreMetadata is the list of metadata fields to strip | ||
| // when --strip is supplied | ||
| var ignoreMetadata = []string{ |
There was a problem hiding this comment.
managedFields should also be dropped. They usually appear on resources extracted off a running cluster with 'kubectl get` and are technically a read-only field from the POV of the client.
There was a problem hiding this comment.
Yeah it is on the list it's just hidden by this diff 😄
|
|
||
| // stripServerSideFields removes fields that have been added on the | ||
| // server side after the resource was created such as the status field | ||
| func stripServerSideFields(doc cty.Value) cty.Value { |
There was a problem hiding this comment.
Not for this PR, but this function seems a prime candidate for some unit testing. Looks nicely isolated with (almost) no dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repl package in Terraform core was updated to include heredoc formatting
for multiline strings.
The interface for the terraform/repl package changed to use cty.Value
rather than map[string]interface{} so I had to bring in cty as a dependency
and update the code that munges the manifest after it has been decoded to use it.
Closes #13
Multi-line support looks like this: