-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project structure, combining ember pdf js efforts #1
Comments
Hi @jrhe, Emberizing the viewer in a second project sounds like a good idea. But shouldn't we focus on just two repos? One that does something similar to mine and one that Emberizes the viewer based on that? |
@rmachielse I guess it depends on what the extra bits over and above just setting up the library there are. I figured most use cases would be one or the other and it didn't make sense to include two sets of viewer code in any project. I guess it would make sense to first clarify how people are/ will want to use pdf-js in their ember projects. |
Here's a link to my repo's goals. mysterlune/ember-pdfjs#2 (comment) I am mainly interested in a project that:
in my mind, controls and pagers and print buttons, etc. should be left up to other component developers to build as addons. i think the core project should be "all about the document and its content"... not necessarily at all about navigating/manipulating the document (other than scrolling)... thoughts? |
hi donald, the currently active project is: https://github.com/mysterlune/ember-pdfjs as far as i know, anyway. my team is kicking off a round of development on i've been using this project for prototyping a document viewing application ideally, the component will be (like what ember list view does) a i'm happy to accept PRs or respond to issues that you post... cheers, On Mon, Dec 28, 2015 at 7:35 PM, Donald Wasserman notifications@github.com
|
Others have taken a crack at getting pdf.js working with ember but the projects didn't meet the needs of my project (full mozilla viewer) or were incomplete (no cmaps, no compatability.js) so I created this project.
https://github.com/mysterlune/ember-pdfjs
https://github.com/rmachielse/ember-cli-pdfjs
Ideally I think we need the following projects to cover all use cases and minimise duplication:
ember-pdf-js
Imports and sets up pdf.js without a viewer. People can then implement their own viewer or
ember-pdf-js-viewer
Uses ember-pdf-js to set up pdf-js and contains an emberified version of the mozilla viewer with as much of its functionality as possible (paging, printing, side panel with
ember-pdf-js-alt-viewer
A custom bare bones pdf viewer, built from scratch for ember. Similar to what @rmachielse is trying to achieve.
The text was updated successfully, but these errors were encountered: