Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project structure, combining ember pdf js efforts #1

Open
jrhe opened this issue Jul 6, 2015 · 4 comments
Open

Project structure, combining ember pdf js efforts #1

jrhe opened this issue Jul 6, 2015 · 4 comments

Comments

@jrhe
Copy link
Owner

jrhe commented Jul 6, 2015

Others have taken a crack at getting pdf.js working with ember but the projects didn't meet the needs of my project (full mozilla viewer) or were incomplete (no cmaps, no compatability.js) so I created this project.

https://github.com/mysterlune/ember-pdfjs
https://github.com/rmachielse/ember-cli-pdfjs

Ideally I think we need the following projects to cover all use cases and minimise duplication:

ember-pdf-js

Imports and sets up pdf.js without a viewer. People can then implement their own viewer or

ember-pdf-js-viewer

Uses ember-pdf-js to set up pdf-js and contains an emberified version of the mozilla viewer with as much of its functionality as possible (paging, printing, side panel with

ember-pdf-js-alt-viewer

A custom bare bones pdf viewer, built from scratch for ember. Similar to what @rmachielse is trying to achieve.

@rmachielse
Copy link

Hi @jrhe, Emberizing the viewer in a second project sounds like a good idea. But shouldn't we focus on just two repos? One that does something similar to mine and one that Emberizes the viewer based on that?

@jrhe
Copy link
Owner Author

jrhe commented Jul 6, 2015

@rmachielse I guess it depends on what the extra bits over and above just setting up the library there are. I figured most use cases would be one or the other and it didn't make sense to include two sets of viewer code in any project.

I guess it would make sense to first clarify how people are/ will want to use pdf-js in their ember projects.
If those who have some interest in using pdf.js in their projects could clarify what their intentions are it might help (@mysterlune, @achambers, @knownasilya).

@mysterlune
Copy link

Here's a link to my repo's goals.

mysterlune/ember-pdfjs#2 (comment)

I am mainly interested in a project that:

  • "brings PDFJS into an Ember project"
  • ships with a basic component (canvas based) for displaying a list of pages
  • exposes various hooks for component level events like for highlighting

in my mind, controls and pagers and print buttons, etc. should be left up to other component developers to build as addons. i think the core project should be "all about the document and its content"... not necessarily at all about navigating/manipulating the document (other than scrolling)...

thoughts?

@mysterlune
Copy link

hi donald,

the currently active project is:

https://github.com/mysterlune/ember-pdfjs

as far as i know, anyway. my team is kicking off a round of development on
this project.

i've been using this project for prototyping a document viewing application
in ember, and have brought this project current with the ember component
and addon practices. however, the component pdf-page doesn't have the
best api as i've written it, and only really serves one page :(

ideally, the component will be (like what ember list view does) a
lazy-loadable list of pdf pages that the user can scroll through or jump to
a particular page... mucho work needs to be done. but, as mentioned, i've
got the opportunity to focus team efforts on this project.

i'm happy to accept PRs or respond to issues that you post...

cheers,
river

On Mon, Dec 28, 2015 at 7:35 PM, Donald Wasserman notifications@github.com
wrote:

Hi there - i've come across this project and want to learn more. Is anyone
still working on this?


Reply to this email directly or view it on GitHub
#1 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants