Hide wiki markup as part of markdown-toggle-markup-hiding #861
Conversation
|
9a7bd6d to
4d44c6a
Compare
… link tests to be with other wiki link tests
|
I fixed the byte compiler warnings and updated the wiki link tests to check that the face properties are properly being set to support markup hiding. I think I've done everything that's called out in Wiki links seemed to be handled very different front inline and reference links. I couldn't find a reason for the two different approaches, and it make some of the implementation more difficult than it needed to be, so some of my changes have the effect of treating wiki links much more like reference and inline links. If I misunderstood this and there's a reason for the two different approaches please let me know. (That's only if |
|
I see this workflow is halted with the message that it is awaiting approval from a maintainer. Is there anything I can do or need to do in order to get this branch through the build pipeline? |
|
@syohex fixed merge conflicts and failing tests from recent updates to mouse face in links |
| @@ -3394,23 +3395,6 @@ the buffer)." | |||
| (defun markdown-match-yaml-metadata-key (last) | |||
| (markdown-match-propertized-text 'markdown-metadata-key last)) | |||
|
|
|||
| (defun markdown-match-wiki-link (last) | |||
There was a problem hiding this comment.
Please don't remove public interfaces, this causes breaking backward compatibility
| @@ -8451,39 +8510,6 @@ See `markdown-wiki-link-p' and `markdown-follow-wiki-link'." | |||
| (markdown-follow-wiki-link (markdown-wiki-link-link) arg) | |||
| (user-error "Point is not at a Wiki Link"))) | |||
|
|
|||
| (defun markdown-highlight-wiki-link (from to face) | |||
There was a problem hiding this comment.
Please don't remove public interfaces, this causes breaking backward compatibility
| "Highlight the wiki link in the region between FROM and TO using FACE." | ||
| (put-text-property from to 'font-lock-face face)) | ||
|
|
||
| (defun markdown-unfontify-region-wiki-links (from to) |
There was a problem hiding this comment.
Please don't remove public interfaces, this causes breaking backward compatibility
| ;; undo that if it wasn't originally marked modified | ||
| (set-buffer-modified-p modified))) | ||
|
|
||
| (defun markdown-fontify-region-wiki-links (from to) |
There was a problem hiding this comment.
Please don't remove public interfaces, this causes breaking backward compatibility
| @@ -8502,50 +8528,6 @@ newline after." | |||
| (setq new-to (point))) | |||
| (cl-values new-from new-to))) | |||
|
|
|||
| (defun markdown-check-change-for-wiki-link (from to) | |||
There was a problem hiding this comment.
Please don't remove public interfaces, this causes breaking backward compatibility
| (buffer-modified-p) | ||
| (set-buffer-modified-p nil))))) | ||
|
|
||
| (defun markdown-check-change-for-wiki-link-after-change (from to _) |
There was a problem hiding this comment.
Please don't remove public interfaces, this causes breaking backward compatibility
| Designed to be used with the `after-change-functions' hook." | ||
| (markdown-check-change-for-wiki-link from to)) | ||
|
|
||
| (defun markdown-fontify-buffer-wiki-links () |
There was a problem hiding this comment.
Please don't remove public interfaces, this causes breaking backward compatibility
| (markdown-reload-extensions)) | ||
|
|
||
| (defun markdown-setup-wiki-link-hooks () |
There was a problem hiding this comment.
Please don't remove public interfaces, this causes breaking backward compatibility
When markup hiding is enabled, the markup for markdown-style links is hidden, but the markup for wiki links is not. This code change fontifies the different sections of wiki links so that they are properly supported by
markdown-toggle-markup-hiding.Related Issues
The changes address issues #557, #782, and #847.
Type of Change
Checklist
make test).