Fix language correcting script #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Original code does not return language list. It returns value of kill-buffer - Original code ignores language which contains space like 'Emacs Lisp' - Replace space with '-' like 'Emacs Lisp' -> 'Emacs-Lisp'
|
Good work! |
|
Great, thanks! I only have one question: Does GitHub expect or require the spaces to be replaced by hyphens? In my limited testing, it seems so. For example, blocks beginning with |
|
This seems to show that hyphens are indeed used. |
|
Thanks for finding that! I think the patch is probably good as is then. After experimenting some more (in comments), it seems that to use spaces you have to enclose the language name in braces, like this ```` {Emacs Lisp}`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And update language list.
This is related to #72.
CC: @blaenk