Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moving same level header over code block issue #77

Merged
merged 2 commits into from
Jan 15, 2016

Conversation

syohex
Copy link
Collaborator

@syohex syohex commented Jan 15, 2016

This is related to #75.
CC: @walmes, @jrblevin

Test code is here.
@walmes Should I add more tests ? If I missed some test cases, please tell me them.

@jrblevin
Copy link
Owner

This is interesting. There was already a test like this one. In fact, there is a special Markdown file outline-code.text designed to test this. It's strange that those were passing but this new test fails (before your patch).

EDIT: The previous tests are test-markdown-outline/navigation-with-code (line 2675) and test-markdown-outline/visibility-with-code (line 2731).

@jrblevin jrblevin merged commit 50a835d into jrblevin:master Jan 15, 2016
@jrblevin
Copy link
Owner

I merged this just now. Thanks once again!

@syohex syohex deleted the moving-over-code-block branch January 15, 2016 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants