Safer convert to filename #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you put something like [[/!foo website="http://bar.baz"]] in a markdown file, the conversion to filename will start failing with tramp-related errors. This is particularly bad because fontification happens on window configuration change, so killing the buffer and/or switching away from it also fail. Fix: for the normal case, escape without testing the filesystem. Wrap a condition-case around for when the user has specified search-parent-directories.
It's all very well fixing the filename finding, but we also need to prevent the fontification engine itself asking about invalid tramp files.
|
Thanks for these patches! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With sufficiently evil contents in [[Wikilinks]], it's possible to confuse emacs and tramp to the point that they won't let you switch away from the buffer. Handle conditions appropriately when examining the filesystem for
files named by wikilink content.