don't add global hooks for live-preview #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrblevin
pushed a commit
that referenced
this pull request
Jan 5, 2016
Take global hooks and make them buffer-local. markdown-live-preview-remove-on-kill applies to both the Markdown buffers and the buffers used to preview the export, so it needs to be re-added in two places, where the export-viewing buffer is created, and when markdown-mode is turned on. The test test-markdown-ext/live-preview-exports adequately covers whether these hooks run. [jrblevin@sdf.org: Squashed two commits and rebased. Added GH-63 PR text to commit message for reference.] Signed-off-by: Jason Blevins <jrblevin@sdf.org>
|
Thanks. Applied as 002680d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take global hooks and make them buffer-local.
markdown-live-preview-remove-on-killapplies to both the markdown buffers and the buffers used to preview the export, so it needs to be re-added in two places, where the export-viewing buffer is created, and whenmarkdown-modeis turned on.The test
test-markdown-ext/live-preview-exportsadequately covers whether these hooks run.