Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cl-lib #58

Merged
merged 2 commits into from
Jan 4, 2016
Merged

use cl-lib #58

merged 2 commits into from
Jan 4, 2016

Conversation

cosmicexplorer
Copy link
Contributor

I was having issues with cl vs cl-lib byte compiling correctly, so I just turned everything to cl-lib. If there's a reason we're sticking to cl then just close this.

@jrblevin
Copy link
Owner

jrblevin commented Jan 4, 2016

Since cl-lib is now recommended, I agree that we should switch to that. I also don't personally have any reservations about requiring it at runtime since it has been bundled with Emacs for a while. Aiming for compatibility with Emacs before 24.3 or so is getting harder and harder. Perhaps we should add a note about the dependency for Emacs 24.1 and 24.2 users, who can use package.el?

@jrblevin jrblevin merged commit 793e79a into jrblevin:master Jan 4, 2016
@cosmicexplorer
Copy link
Contributor Author

A note about the dependency should definitely be added. I'd just stick it in the README under "Installation," since MELPA downloads dependencies automatically.

@jrblevin
Copy link
Owner

jrblevin commented Jan 5, 2016

Thanks. I went ahead and added it last night in 4260e68, but I put it under a new section titled "Compatibility".

@cosmicexplorer
Copy link
Contributor Author

Oops, just saw you added it (sorry, laptop just crashed). I'd recommend at least referencing the "Compatibility" section from "Installation", since the only people reading "Installation" are the ones not using MELPA, and therefore the ones that might need to know beforehand to install cl-lib.

@jrblevin
Copy link
Owner

jrblevin commented Jan 5, 2016

No worries. It was easy to miss. Here's the newly updated version: 1ee52a1. Let me know if you think it needs any other changes.

@cosmicexplorer
Copy link
Contributor Author

Yeah, that sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants