Add to beginning of auto-mode-alist, not end #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Emacs 26, a file called 'CHANGELOG.md' will open in `changelog-mode' instead of `markdown-mode', because a regexp was added to `auto-mode-alist' that matches the 'CHANGELOG' part of the filename. In order for the file to correctly open in `markdown-mode', the regexps for `markdown-mode' must be added earlier in `auto-mode-alist', hence this commit. There should be no concern about this overriding user configuration, since it makes no sense for user configuration code to be run before the autoloads for `markdown-mode' are evaluated.
|
@jrblevin Ping :-) This fixes an extremely annoying issue on Emacs 26, so I think it's worth merging the the PR. |
|
Thank you! 🙏
On Sat, 7 Jul 2018 at 15:00, Jason Blevins ***@***.***> wrote:
Thanks for the reminder, and thanks @raxod502
<https://github.com/raxod502> for the patch! Rebased and applied as
b92f00d
<b92f00d>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#335 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGVyjjUnD7wH1q6t0EIJfrhonYEc-Opks5uELEAgaJpZM4T1OmV>
.
--
Best Regards,
Bozhidar Batsov
http://www.batsov.com
|
raxod502
added a commit
to radian-software/radian
that referenced
this pull request
Jul 7, 2018
Pull request was merged: jrblevin/markdown-mode#335.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Emacs 26, a file called
CHANGELOG.mdwill open inchangelog-modeinstead ofmarkdown-mode, because a regexp was added toauto-mode-alistthat matches theCHANGELOGpart of the filename. In order for the file to correctly open inmarkdown-mode, the regexps formarkdown-modemust be added earlier inauto-mode-alist, hence this pull request.There should be no concern about this overriding user configuration, since it makes no sense for user configuration code to be run before the autoloads for
markdown-modeare evaluated.This solves #331 and addresses my comment at #127 (comment).
This is a breaking change, but only barely—if someone were relying on the previous behavior, I would consider it extraordinarily bad practice.
Checklist
make test).Let me know if you think a test is required for this change.