skip empty URLs when inlining images #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markdown links like `[foo]()`, while basically invalid, do not usually
cause too much trouble, or at least shouldn't cause problems in
unrelated code. It so happens that if a document happens to have such
a link, `markdown-toggle-inline-images` will crash with:
insert-file-contents-literally: not a regular file: /tmp/default-directory-path/
This patch fixes the problem by checking if the `file` path extracted
from the regex is empty before proceeding with treating it like an image.
|
no new tests fail, but i haven't added test cases for this bug because there's no test case for |
|
Thanks for the patch! Applied as baf23cb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Markdown links like
[foo](), while basically invalid, do not usuallycause too much trouble, or at least shouldn't cause problems in
unrelated code. It so happens that if a document happens to have such
a link,
markdown-toggle-inline-imageswill crash with:This patch fixes the problem by checking if the
filepath extractedfrom the regex is empty before proceeding with treating it like an image.
Type of Change
Checklist
make test).