Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce user option to translate absolute filenames #277

Merged
merged 1 commit into from
Nov 1, 2017

Conversation

phst
Copy link
Contributor

@phst phst commented Oct 29, 2017

Related Issue

#268

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have updated the documentation at the beginning of markdown-mode.el if needed.
  • If documentation was added or changed, I have updated the README.md file using webpage.sh.
  • I have added an entry to CHANGES.md.
  • I have added tests to cover my changes.
  • All new and existing tests passed (using make test).

@phst phst force-pushed the bug268 branch 2 times, most recently from 35f7048 to edcc09f Compare October 29, 2017 18:37
@jrblevin
Copy link
Owner

This looks fine to me, but before committing I wondered if it should be generalized to allow translating all paths, not only absolute paths? For example, one use case might be to add a file extension to an extensionless URL. Any thoughts?

@phst
Copy link
Contributor Author

phst commented Oct 31, 2017

Yes, that sounds simpler. Updated the PR.

@jrblevin jrblevin merged commit 7a62259 into jrblevin:master Nov 1, 2017
@jrblevin
Copy link
Owner

jrblevin commented Nov 1, 2017

Great, thanks for the patch!

@phst phst deleted the bug268 branch December 9, 2017 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants