Set font style for GFM-style code blocks in base markdown-mode, too. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github Flavored Markdown isn't the only one that supports fenced-code blocks annotated with a string controlling things like syntax highlighting. That's also part of the Common Mark spec (http://spec.commonmark.org/0.20/#info-string). There's room to be permissive here. The syntax for a GFM-style code block is unlikely to show up in Markdown code in other contexts. And failing to do so makes those code-blocks much harder to read in the source (e.g. because Python comments are highlighted as headers and so on).
|
Applied, thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Flavored Markdown isn't the only one that supports fenced-code blocks
annotated with a string controlling things like syntax highlighting. That's also
part of the Common Mark spec (http://spec.commonmark.org/0.20/#info-string).
There's room to be permissive here. The syntax for a GFM-style code block is
unlikely to show up in Markdown code in other contexts. And failing to do so
makes those code-blocks much harder to read in the source (e.g. because
Python comments are highlighted as headers and so on).