Unmark buffer modified at markdown-unfontify-region-wiki-links #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Emacs 24.3 some `remove-text-properties` calls, like the ones in `markdown-unfontify-region-wiki-links`, mark the buffer modified. This function is invoked by default from `markdown-mode`, and so it makes that a Markdown buffer is marked modified just by visiting a file or changing to this major mode. This change unsets the buffer modified mark if it wasn't previously set.
|
Merged--thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Emacs 24.3 (tested Emacs 24.3.1 from Ubuntu 14.04 LTS) any Markdown buffer is marked as modified at creation when visiting the file (or activating the markdown major mode). This couldn't be reproduced in some later Emacs versions, like 24.4.1 from Debian Jessie.
The test / bisect script used to reproduce the bug is:
The bisection showed that the commit that introduced this behavior was 3c2cfee, where the function
markdown-unfontify-region-wiki-linksis invoked frommarkdown-modeunless some non-default settings prevent it.The problem seems to be that in Emacs 24.3 some
remove-text-propertiescalls, like the ones inmarkdown-unfontify-region-wiki-links, mark the buffer modified. The proposed change unsets the buffer modified mark if it wasn't previously set.