Implement inline image feature #128
Conversation
|
Wow, only 40 lines. I thought this would be a much larger undertaking! Nice work. I won't be able to actually test it out for a day or two, but I looked at the patch and it looks good to me. I think keybindings are a good idea. Image insertion is under C-c C-i, so maybe C-c C-i C-t for toggling? |
|
That's awesome, thank you! I was also assuming it'd be a lot more code to get that to work. |
| (error "Cannot show images.")) | ||
| (save-excursion | ||
| (save-restriction | ||
| (widen) |
There was a problem hiding this comment.
Do you need to widen here?
My question's context: I'm thinking for my use-case I'll probably narrow to region of the day I'm writing in, and only want the pictures toggles for that day (toggling them for all days could make things slow, particularly because I intend to hook into this code & use ImageMagik to make the photos no wider than the buffer size).
There was a problem hiding this comment.
I took most of code from org-mode and org inline image commands uses widen. Commands which I add works same as org-mode commands(org-toggle-inline-images etc).
@jrblevin Thanks for suggestion. I'll add bindings later. |
|
I have set toggle command to |
This is related to #122.
CC: @ihodes
Should we add key bindings for those commands by default ?
See