Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suboptimal failure modes for markdown-open and markdown commands #291

Closed
phst opened this issue Nov 20, 2017 · 1 comment · Fixed by #301
Closed

Suboptimal failure modes for markdown-open and markdown commands #291

phst opened this issue Nov 20, 2017 · 1 comment · Fixed by #301

Comments

@phst
Copy link
Contributor

phst commented Nov 20, 2017

Expected Behavior

The commands markdown-open and markdown should provide a meaningful error message when markdown-open-command and markdown-command fail or don't exist, respectively.

Actual Behavior

Both commands silently do nothing if the external subprocess fails. In addition, markdown silently does nothing if the program file doesn't exist.

Steps to Reproduce

In a Markdown buffer:

(let ((markdown-command "/bin/false")) (markdown))
(let ((markdown-command "/does/not/exist")) (markdown))
(let ((markdown-open-command "/bin/false")) (markdown-open))

Software Versions

  • Markdown Mode: 2.3
  • Emacs: 26.0.90
  • OS: Debian testing
@jrblevin
Copy link
Owner

Thanks, I agree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants