This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
autoscale: provide additional decision context on scaling choices #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the autoscaler performs its logic to figure out whether a scaling event should be triggered, it uses a case statement to check if thresholds are broken. The problem with this is that the first match is used, which is correct, but doesn't provide a great amount of detail. It is possible that both out and in actions are desired by different resources, or that multiple resources both require the same action. This change allows for greater insight into the scaling decision made by the autoscaler calculation. It helps operators understand if changes need to be made to group resource settings, or exactly which thresholds were broken.
|
fyi @commarla |
|
Nice ! I like it. The behaviour is the same and the new message is crystal clear. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the autoscaler performs its logic to figure out whether a
scaling event should be triggered, it uses a case statement to
check if thresholds are broken. The problem with this is that the
first match is used, which is correct, but doesn't provide a great
amount of detail. It is possible that both out and in actions are
desired by different resources, or that multiple resources both
require the same action.
This change allows for greater insight into the scaling decision
made by the autoscaler calculation. It helps operators understand
if changes need to be made to group resource settings, or exactly
which thresholds were broken.