This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Fix incorrect response code and msg when scaling breaks thresholds #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously errors when triggering a scaling action such as the new count breaking policy thesholds would result in a 304 response code and an empty message. This changes fixes the behaviour so that the client will recieve a 409 response code with a useful message to indicate the reason for not performing the action. Closes #59
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously errors when triggering a scaling action such as the
new count breaking policy thesholds would result in a 304 response
code and an empty message. This changes fixes the behaviour so
that the client will recieve a 409 response code with a useful
message to indicate the reason for not performing the action.
Closes #59