This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Add metrics API endpoint and CLI command #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to sending telemetry to an endpoint, this commit now allows metrics to be viewed by calling the Sherpa API. A command can also be used, which wraps the API, to output the telemetry information to the terminal. The API and command are nested under the system commands and endpoints.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature enhancement which takes previous telemetry work and adds an API endpoint and CLI command.
What this PR does / why we need it:
This adds both an API and CLI command for viewing the latest telemetry data points from a Sherpa server. This means operators can quickly get an idea for the server performance and will later allow the addition of Prometheus metrics output which will allow Prometheus exporter to run crawls on the Sherpa API.