-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DnD): use custom event wrapper component while dragging #1865
feat(DnD): use custom event wrapper component while dragging #1865
Conversation
This change allows to use custom EventWrapper component on preview event
e91490d
to
f181248
Compare
Nice, this is useful. |
@nlevchuk There were a large number of unresolved file conflicts with your branch, but your changes were easily replicated on a fresh branch. Changes are now in current build. |
@cutterbl It's two-line changes. I even could create fresh branch from the main one and create new PR if you told me about it. It would save my contribution to the project |
@cutterbl In modern world it calls "stolen code" |
@nlevchuk I tell you what. I'll pull the changes out, and let you reapply. I really wasn't trying to 'steal' your code, or I wouldn't have posted anything here in the first place. I was just trying to get the changes in. Would that be OK with you? |
it is a shame. |
@cutterbl I appreciate your work on the project and thank you for that. Look at this situation from my side: One of contributors creates a PR with identical changes, merge it to the main branch, close my PR and trying to tell me that what he did is normal. What do you feel if it would happen with you?
I guess it's fair |
@nlevchuk Everyone has a different perspective. I was just trying to move forward a minor change that could obviously be helpful to others, but had sat for four months. But, I see your point of view as well. The changes have been pulled. Please reapply them at your earliest convenience, so that other's may benefit from the change. |
Even if you did your changes from the best intention you played down my work: I spent time creating the issue and the PR. I'm going to make the changes right away |
This change allows to use custom EventWrapper component on preview event
Closes #1864