Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OSD visibility #7

Closed
RWeigelt opened this issue Nov 3, 2020 · 8 comments
Closed

Improve OSD visibility #7

RWeigelt opened this issue Nov 3, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@RWeigelt
Copy link

RWeigelt commented Nov 3, 2020

When viewed from the corner of my eye, the OSD works very well on dark backgrounds, but not on light backgrounds or on some backgrounds with colored areas.

Here is an example (VS2019):
image

I suggest adding a dark border:
image
(It does not necessarily have to be pure black as shown in the mockup)

A shadow could be an alternative:
image
(I didn't spend much time on tweaking the shadow, looks kind of "dirty" in some parts)

Personally, I'd prefer the border, though.

@RWeigelt RWeigelt added the enhancement New feature or request label Nov 3, 2020
@jpwilliams jpwilliams self-assigned this Nov 3, 2020
@jpwilliams
Copy link
Owner

Aye I completely agree with this - I have suffered the same annoyance!

In an earlier version the OSD did actually have shadow, but this required window transparency which seemed to be causing some flickering when the OSD spawned, thus it was removed.

A border would indeed be a lovely addition. It's on my list. 👍

@jpwilliams
Copy link
Owner

@RWeigelt I've added a thin blue border to the OSD in v2.0.8.

I tested primarily on top of browsers, but also against my own Visual Studio and it seems to be clear enough. Please feel free to re-open if it's still a bit too hard to see and we can look in to some other options (maybe pure black is the way to go!).

@RWeigelt
Copy link
Author

RWeigelt commented Nov 5, 2020 via email

@RWeigelt
Copy link
Author

RWeigelt commented Nov 5, 2020

@jpwilliams Maybe replying by email wasn't a good idea, seems like it didn't keep the attachment.
So I'll add the mockups here:

Border two pixels wide, blue (2.0.8)

image

image

Border three pixels wide, blue

image

image

Border four pixels wide, blue

image

image

Border one pixel wide, black

image

image

Border two pixels wide, black

image

image

Border three pixels wide, black

image

image

@jpwilliams
Copy link
Owner

Crikey, @RWeigelt! Thanks this really thorough spread of border examples! 🤩 Never thought I'd get excited about seeing borders. 😀

Bizarrely, I actually really like the chunky 4-pixel blue border, but I'm confident that won't be to everyone's taste!

From your examples I agree with the border being at least 2 pixels; it definitely gets lost if it's only 1. It's a shame as some transparency (meaning the ability to add a shadow) would really help with this. I might do some tests with transparency again and see if I can circumvent the flickering we were experiencing before, as even a chunky black border can get a bit lost.

There's also the possibility to provide the ability to customise the OSD in terms of colours/sizing so people could use whatever border colour/size they want, but there's a balance to be struck between educated recommendations and providing too much customisation. As someone that looks be pretty heavily involved in UX, I'd love to hear your opinion on this!

@jpwilliams jpwilliams reopened this Nov 6, 2020
@RWeigelt
Copy link
Author

RWeigelt commented Nov 6, 2020

Hi @jpwilliams, with a night's sleep between creating the mockups and looking at them, I'd go with the black, two-pixel border.

I think it's a good compromise:

  • It provides good visibility on virtually any background.
  • It does not look like an explicit design statement and does not interfere with the design of the OSD.

@jpwilliams jpwilliams added this to the v2.0.9 milestone Nov 7, 2020
@jpwilliams
Copy link
Owner

Cool I think I agree - this'll appear in v2.0.9 along with a couple of bug fixes.

@jpwilliams
Copy link
Owner

Border changed to 2px black in v2.0.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants