Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change to fs-extra #26

Closed
raymondfeng opened this issue Jun 23, 2015 · 5 comments
Closed

Breaking change to fs-extra #26

raymondfeng opened this issue Jun 23, 2015 · 5 comments

Comments

@raymondfeng
Copy link

The commit 3ce00a5 breaks https://github.com/jprichardson/node-fs-extra/blob/master/lib/index.js as this.spaces now refers to fs.spaces which is always undefined.
@raymondfeng raymondfeng mentioned this issue Jun 23, 2015
Closed
@jprichardson
Copy link
Owner

Ooops! Sorry, fixing...

raymondfeng pushed a commit to strongloop/loopback-workspace that referenced this issue Jun 23, 2015
Workaround for jprichardson/node-jsonfile#26
1d125e8
raymondfeng pushed a commit to strongloop/loopback-workspace that referenced this issue Jun 23, 2015
3.15.1
a0a9eea 
 * Workaround for jprichardson/node-jsonfile#26 (Raymond Feng)
@jprichardson
Copy link
Owner

Sorry about that. Published and fixed in 0.20.1.

@jprichardson
Copy link
Owner

Gah, I made the fix in fs-extra... :(

@jprichardson
Copy link
Owner

I'm not sure if there's anything to fix here.... If you feel differently, please reopen, but the fix exists in fs-extra@0.20.1.

@jprichardson
Copy link
Owner

As of jsonfile@2.2.0, you can no explicitly set spaces in the methods writeFile() or writeFileSync(). Just pass in locally {spaces: 2}. All you'd need to do is reinstall your current version of fs-extra that supports ^jsonfile@2.0.0.

@kevinji kevinji mentioned this issue Jul 14, 2015
Closed
reactDev037 added a commit to reactDev037/Workspace-backend that referenced this issue Sep 5, 2018
@reactDev037
Workaround for jprichardson/node-jsonfile#26
14ffe56
reactDev037 added a commit to reactDev037/Workspace-backend that referenced this issue Sep 5, 2018
@reactDev037
3.15.1
189af79 
 * Workaround for jprichardson/node-jsonfile#26 (Raymond Feng)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jprichardson @raymondfeng