Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests are failing in node.js 14 #798

Closed
manidlou opened this issue May 13, 2020 · 0 comments · Fixed by #800
Closed

Some tests are failing in node.js 14 #798

manidlou opened this issue May 13, 2020 · 0 comments · Fixed by #800
Assignees

Comments

@manidlou
Copy link
Collaborator

  • Operating System: Ubuntu 18.04.4
  • Node.js version: 14.2.0
  • fs-extra version: 9.0.0

These tests are failing in node.js 14 while everything is fine in node.js 13!

1) fs-extra
       + createFile
         > when the file does exist
           should give clear error if node in directory tree is a file:
     TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received undefined
      at Object.writeFileSync (fs.js:1380:5)
      at Context.<anonymous> (lib/ensure/__tests__/create.test.js:49:12)

  2) fs-extra
       + createFileSync
         > when the file does exist
           should give clear error if node in directory tree is a file:
     TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received undefined
      at Object.writeFileSync (fs.js:1380:5)
      at Context.<anonymous> (lib/ensure/__tests__/create.test.js:82:12)

  3) remove
       + remove()
         should delete a directory full of directories and files:
     TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received undefined
      at Object.writeFileSync (fs.js:1380:5)
      at buildFixtureDir (lib/remove/__tests__/remove.test.js:24:6)
      at Context.<anonymous> (lib/remove/__tests__/remove.test.js:47:7)
@RyanZim RyanZim self-assigned this May 14, 2020
RyanZim added a commit that referenced this issue May 14, 2020
Fixes #798

writeFileSync requires a data parameter
RyanZim added a commit that referenced this issue May 14, 2020
* Fix tests on Node 14

Fixes #798

writeFileSync requires a data parameter

* Add Node 14 to CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants