Improve Test Compiling #2338
Merged
Improve Test Compiling #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0101272 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AlbertoBrusa
commented
May 2, 2023
| @@ -36,7 +36,7 @@ jobs: | |||
| - name: 'Build internal prerequisites' | |||
| run: yarn workspace @modular-scripts/workspace-resolver build | |||
| - name: Run Tests | |||
| run: yarn test --coverage | |||
| run: yarn test --coverage --regex="./packages/*" | |||
There was a problem hiding this comment.
yarn test won't work for us, cause most of our packages aren't actual modular packages
AlbertoBrusa
commented
May 2, 2023
| @@ -14,7 +14,7 @@ | |||
| "lint:fix": "yarn lint --fix", | |||
| "create-modular-react-app": "ts-node packages/create-modular-react-app/src/cli.ts", | |||
| "modular": "ts-node packages/modular-scripts/src/cli.ts", | |||
| "test": "cross-env NODE_OPTIONS=--max_old_space_size=5120 yarn modular test --regex --watchAll false --runInBand --env node --transformIgnorePatterns \"node_modules/(?!rollup)/\"", | |||
| "test": "cross-env NODE_OPTIONS=--max_old_space_size=5120 yarn modular test --swc --runInBand --env=node", | |||
There was a problem hiding this comment.
Over time between test bugs and trying to make things work I must have messed up our default test command - should be alright now
AlbertoBrusa
commented
May 2, 2023
| "@types/case-sensitive-paths-webpack-plugin": "^2.1.6", | ||
| "@types/lodash": "^4.14.191", | ||
| "@types/micromatch": "4.0.2", | ||
| "@types/node": "^18.11.18", | ||
| "@types/npmcli__arborist": "^5.6.0", | ||
| "@types/postcss-normalize": "^9.0.1", | ||
| "@types/shell-quote": "^1.7.1", | ||
| "@types/webpack": "^5.28.0", |
There was a problem hiding this comment.
not sure why this got removed? - don't remember doing it.
nothing broke so I'm wondering if the types came with webpack already and this was unnecessary
ayseenver
approved these changes
May 2, 2023
cristiano-belloni
approved these changes
May 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esmView test run locally:
previously took: 163s
Now takes: 89s
Overall test times seem to be down anywhere between 5-10 minutes (varies run to run)