Fix repository field generation on Windows #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f88456b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/modular-scripts/src/build/buildPackage/getRepositoryField.ts
Outdated
Show resolved
Hide resolved
c202fa7 to
79d614e
Compare
cristiano-belloni
suggested changes
Dec 7, 2022
79d614e to
f88456b
Compare
joshwooding
commented
Dec 7, 2022
| return path.relative(gitRepoPath, packagePath); | ||
| return path | ||
| .relative(gitRepoPath, packagePath) | ||
| .split(path.win32.sep) |
There was a problem hiding this comment.
This is the same as the utils in esbuild-scripts, so probably can be cleaned up in the future to use the same utility
|
Any update on this? |
cristiano-belloni
approved these changes
Dec 9, 2022
Sorry, didn't get a notification on your latest changes. Merged. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.