Node 18 & Jest 29

.changeset/fluffy-dragons-behave.md

@@ -0,0 +1,14 @@
+---
+'create-modular-react-app': major
+'eslint-config-modular-app': major
+'modular-scripts': major
+'modular-template-app': patch
+'modular-template-esm-view': patch
+'modular-template-view': patch
+---
+
+Added Node 18 engine support
+Upgraded Jest from 26 to 29 as 26 wasn't compatible with Node 18
+Upgraded to rollup-plugin-esbuild 5, dropping support for Node 14.17 and below
+Supported Node versions now: ^14.18.0 || >=16.10.0 || >=18.0.0
+Changed Jest flag --watchAll default to false (was previously true if running locally and not in CI)

.github/workflows/release.yml

@@ -20,7 +20,7 @@ jobs:
       - name: Use Node.js
         uses: actions/setup-node@v3.3.0
         with:
-          node-version: '14.17.0'
+          node-version: '14.18.0'
           registry-url: https://registry.npmjs.org/
           cache: 'yarn'
 

.github/workflows/static.yml

@@ -2,9 +2,9 @@ name: Lint
 
 on:
   push:
-    branches: [main, 'release/**']
+    branches: [main, 'release/**', feature/v4]
   pull_request:
-    branches: [main, 'release/**']
+    branches: [main, 'release/**', feature/v4]
 
 jobs:
   Static:
@@ -29,7 +29,7 @@ jobs:
       - name: Use Node.js
         uses: actions/setup-node@v3.3.0
         with:
-          node-version: '14.17.0'
+          node-version: '14.18.0'
           cache: 'yarn'
 
       - name: 'Install Dependencies'

.github/workflows/test-windows.yml

@@ -5,9 +5,9 @@ name: Windows Test
 
 on:
   push:
-    branches: [main, 'release/**']
+    branches: [main, 'release/**', feature/v4]
   pull_request:
-    branches: [main, 'release/**']
+    branches: [main, 'release/**', feature/v4]
 
 jobs:
   Test:
@@ -20,7 +20,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [windows-latest]
-        node-version: ['14.17.0', '16.x']
+        node-version: ['14.18.0', '16.x', '18.x']
 
     steps:
       - uses: actions/checkout@v3

.github/workflows/test.yml

@@ -5,9 +5,9 @@ name: Test
 
 on:
   push:
-    branches: [main, 'release/**']
+    branches: [main, 'release/**', feature/v4]
   pull_request:
-    branches: [main, 'release/**']
+    branches: [main, 'release/**', feature/v4]
 
 jobs:
   Test:
@@ -22,7 +22,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
-        node-version: ['14.17.0', '16.x']
+        node-version: ['14.18.0', '16.x', '18.x']
 
     steps:
       - uses: actions/checkout@v3

.github/workflows/validate.yml

@@ -1,9 +1,9 @@
 name: 'Validate'
 on:
   push:
-    branches: [main, 'release/**']
+    branches: [main, 'release/**', feature/v4]
   pull_request:
-    branches: [main, 'release/**']
+    branches: [main, 'release/**', feature/v4]
 
 jobs:
   check-yarn-lock-registry:

docs/releases/4.0.x.md

@@ -0,0 +1,81 @@
+---
+parent: Release Notes
+title: 4.0.x
+---
+
+# Modular 4.0.0 (IN PROGRESS, EDIT BEFORE RELEASE)
+
+## New Features
+
+- Node 18 Support
+- Updated Jest to [^29.3.1](https://github.com/facebook/jest/releases)
+
+## Breaking Changes
+
+### Upgraded to Jest 29
+
+Jest has been bumped up three major versions from Jest 26, and it comes with a
+number of breaking changes.
+
+We suggest reading through the following migration guides:
+
+- [Jest 26 to 27 Change Log](https://github.com/facebook/jest/releases/tag/v27.0.0)
+- [Jest 27 to 28 Migration Guide](https://jestjs.io/docs/28.x/upgrading-to-jest28)
+  | [Change log](https://github.com/facebook/jest/releases/tag/v28.0.0)
+- [Jest 28 to 29 Migration Guide](https://jestjs.io/docs/next/upgrading-to-jest29)
+  | [Change log](https://github.com/facebook/jest/releases/tag/v29.0.0)
+
+Some noteworthy breaking changes:
+
+- Changed default snapshot formatting options to {escapeString: false,
+  printBasicPrototype: false} as outlined by
+  [this blogpost](https://jestjs.io/blog/2022/04/25/jest-28#future) - Any
+  snapshots tests will have to be updated with the new format, or you can
+  override the snapshotFormat option to the old defaults.
+- As of Jest 28 Jest-Environment-JSDOM is no longer shipped with Jest and needs
+  to be installed separately
+- Jest now includes full support of package.json exports - some existing imports
+  might not resolve correctly
+
+### Upgraded to ESLint 8
+
+(NOT YET DONE, ADD ANY ISSUES/BREAKING CHANGES)
+
+### Removed Commands
+
+We no longer provide the following commands: (FILL AS NEEDED) (PROVIDE/LINK
+DOCUMENTATION FOR HOW TO REPLICATE COMMAND BEHAVIOUR MANUALLY)
+
+### Other
+
+- Jest `--watchAll` flag when running modular test is now `false` by default
+  (Previously set to true unless running in CI)
+- Dropped support for minor versions of Node 14.17 and Node 16 version 16.9 and
+  below
+  - Now support Node ^14.18.0, >=16.10.0, and >=18.0.0
+
+# Merged Changes
+
+ADD WHEN RELEASING
+
+<!-- UPDATE WHEN RELEASING - `modular-scripts` @ 3.4.0 - See
+  [the GitHub release](https://github.com/jpmorganchase/modular/releases/tag/modular-scripts%403.4.0)
+  for full details
+- `create-modular-react-app` @ 3.0.1 - See
+  [the GitHub release](https://github.com/jpmorganchase/modular/releases/tag/create-modular-react-app%403.0.1)
+  for full details
+- `eslint-config-modular-app` @ 3.0.2 - See
+  [the GitHub release](https://github.com/jpmorganchase/modular/releases/tag/eslint-config-modular-app%403.0.2)
+  for full details
+- `@modular-scripts/modular-types` @ 1.1.0 - See
+  [the GitHub release](https://github.com/jpmorganchase/modular/releases/tag/%40modular-scripts%2Fmodular-types%401.1.0)
+  for full details
+- `@modular-scripts/workspace-resolver` @ 1.1.0 - See
+  [the GitHub release](https://github.com/jpmorganchase/modular/releases/tag/%40modular-scripts%2Fworkspace-resolver%401.1.0)
+  for full details -->
+
+# Patch Versions
+
+Patch versions of this release do not have a dedicated summary. For details of
+patch releases, please visit
+[the GitHub releases page](https://github.com/jpmorganchase/modular/releases).

package.json

@@ -5,7 +5,7 @@
     "packages/**"
   ],
   "engines": {
-    "node": "^14.17.0 || >=16.0.0"
+    "node": "^14.18.0 || >=16.10.0 || >=18.0.0"
   },
   "repository": "https://github.com/jpmorganchase/modular.git",
   "scripts": {
@@ -14,7 +14,7 @@
     "lint:fix": "yarn lint --fix",
     "create-modular-react-app": "ts-node packages/create-modular-react-app/src/cli.ts",
     "modular": "ts-node packages/modular-scripts/src/cli.ts",
-    "test": "yarn modular test --watchAll false --runInBand",
+    "test": "yarn modular test --watchAll false --runInBand --env node",
     "build": "yarn workspace @modular-scripts/workspace-resolver build && yarn workspace create-modular-react-app build && yarn workspace modular-scripts build && yarn workspace modular-views.macro build",
     "start": "yarn modular start modular-site",
     "prepare": "is-ci || husky install",
@@ -59,7 +59,7 @@
     "@types/global-modules": "^2.0.0",
     "@types/html-minifier-terser": "6.1.0",
     "@types/is-ci": "3.0.0",
-    "@types/jest": "26.0.24",
+    "@types/jest": "^29.0.0",
     "@types/mime": "^2.0.3",
     "@types/node": "*",
     "@types/npm-packlist": "3.0.0",
@@ -80,6 +80,7 @@
     "execa": "5.1.1",
     "husky": "8.0.1",
     "is-ci": "2.0.0",
+    "jest-environment-jsdom": "^29.3.1",
     "lint-staged": "12.4.1",
     "micromatch": "4.0.5",
     "patch-package": "^6.4.7",

packages/create-modular-react-app/package.json

@@ -11,7 +11,7 @@
     "./package.json": "./package.json"
   },
   "engines": {
-    "node": "^14.17.0 || >=16.0.0"
+    "node": "^14.18.0 || >=16.10.0 || >=18.0.0"
   },
   "scripts": {
     "create-modular-react-app": "ts-node src/cli.ts",

packages/create-modular-react-app/src/__tests__/__snapshots__/index.test.ts.snap

@@ -12,9 +12,9 @@ exports[`create-modular-react-app WHEN it sets up a project with prefer Offline
           "version": "0.1.0",
         }
        1`] = `
-Object {
+{
   "author": "?",
-  "modular": Object {
+  "modular": {
     "type": "app",
   },
   "name": "app",
@@ -83,21 +83,21 @@ exports[`create-modular-react-app WHEN it sets up a project with prefer Offline
           ],
         }
        1`] = `
-Object {
+{
   "author": "?",
-  "browserslist": Object {
-    "development": Array [
+  "browserslist": {
+    "development": [
       "last 1 chrome version",
       "last 1 firefox version",
       "last 1 safari version",
     ],
-    "production": Array [
+    "production": [
       ">0.2%",
       "not dead",
       "not op_mini all",
     ],
   },
-  "dependencies": Object {
+  "dependencies": {
     "@testing-library/dom": "?",
     "@testing-library/jest-dom": "?",
     "@testing-library/react": "?",
@@ -114,31 +114,31 @@ Object {
     "react-dom": "?",
     "typescript": "?",
   },
-  "eslintConfig": Object {
+  "eslintConfig": {
     "extends": "modular-app",
   },
   "license": "MIT",
   "main": "index.js",
-  "modular": Object {
+  "modular": {
     "type": "root",
   },
   "name": "test-repo",
-  "prettier": Object {
+  "prettier": {
     "printWidth": 80,
     "proseWrap": "always",
     "singleQuote": true,
     "trailingComma": "all",
   },
   "private": true,
-  "scripts": Object {
+  "scripts": {
     "build": "modular build",
     "lint": "eslint . --ext .js,.ts,.tsx",
     "prettier": "prettier --write .",
     "start": "modular start",
     "test": "modular test",
   },
   "version": "1.0.0",
-  "workspaces": Array [
+  "workspaces": [
     "packages/**",
   ],
 }
@@ -236,9 +236,9 @@ exports[`create-modular-react-app WHEN setting a project with defaults Sets up a
             "version": "0.1.0",
           }
          1`] = `
-Object {
+{
   "author": "?",
-  "modular": Object {
+  "modular": {
     "type": "app",
   },
   "name": "app",
@@ -307,21 +307,21 @@ exports[`create-modular-react-app WHEN setting a project with defaults Sets up t
             ],
           }
          1`] = `
-Object {
+{
   "author": "?",
-  "browserslist": Object {
-    "development": Array [
+  "browserslist": {
+    "development": [
       "last 1 chrome version",
       "last 1 firefox version",
       "last 1 safari version",
     ],
-    "production": Array [
+    "production": [
       ">0.2%",
       "not dead",
       "not op_mini all",
     ],
   },
-  "dependencies": Object {
+  "dependencies": {
     "@testing-library/dom": "?",
     "@testing-library/jest-dom": "?",
     "@testing-library/react": "?",
@@ -338,31 +338,31 @@ Object {
     "react-dom": "?",
     "typescript": "?",
   },
-  "eslintConfig": Object {
+  "eslintConfig": {
     "extends": "modular-app",
   },
   "license": "MIT",
   "main": "index.js",
-  "modular": Object {
+  "modular": {
     "type": "root",
   },
   "name": "test-repo",
-  "prettier": Object {
+  "prettier": {
     "printWidth": 80,
     "proseWrap": "always",
     "singleQuote": true,
     "trailingComma": "all",
   },
   "private": true,
-  "scripts": Object {
+  "scripts": {
     "build": "modular build",
     "lint": "eslint . --ext .js,.ts,.tsx",
     "prettier": "prettier --write .",
     "start": "modular start",
     "test": "modular test",
   },
   "version": "1.0.0",
-  "workspaces": Array [
+  "workspaces": [
     "packages/**",
   ],
 }

packages/eslint-config-modular-app/package.json

@@ -4,7 +4,7 @@
   "license": "Apache-2.0",
   "main": "index.js",
   "engines": {
-    "node": "^14.17.0 || >=16.0.0"
+    "node": "^14.18.0 || >=16.10.0 || >=18.0.0"
   },
   "exports": {
     ".": "./index.js",