Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular type as an additional property in workspace resolver #2177

Merged
merged 6 commits into from
Oct 10, 2022

Conversation

cristiano-belloni
Copy link
Contributor

@cristiano-belloni cristiano-belloni commented Oct 10, 2022

Provide a type field in the output of resolveWorkspace, containing the modular type of the workspace or a falsy value if not present. This is needed because we want to easily distinguish (and in the feature, support where possible) non-modular packages among our workspaces.

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2022

🦋 Changeset detected

Latest commit: b88cc21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
modular-scripts Patch
@modular-scripts/modular-types Minor
@modular-scripts/workspace-resolver Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Oct 10, 2022

Coverage Status

Coverage decreased (-0.2%) to 33.107% when pulling b88cc21 on feature/modular-type-additional-prop into b3fa5fd on main.

@cristiano-belloni
Copy link
Contributor Author

@steveukx @sgb-io I incorporated your suggestions in the now closed predecessor PR #2169

@cristiano-belloni cristiano-belloni merged commit 8311ade into main Oct 10, 2022
@cristiano-belloni cristiano-belloni deleted the feature/modular-type-additional-prop branch October 10, 2022 16:19
@github-actions github-actions bot mentioned this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants