Support selective version resolutions in esm-views #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8035848 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sgb-io
reviewed
Jun 28, 2022
docs/esm-views/known-limitations.md
Outdated
| particularly relevant in case the `peerDependency` in question is stateful: | ||
| suppose, for example, that one of your ESM Views depends on `react@17.0.1`, but | ||
| one of your dependencies on the CDN depend on `react@>16.8.0` (pretty common if | ||
| the dependency use hooks). Depending on the moment that yor dependency was first |
There was a problem hiding this comment.
Suggested change
| the dependency use hooks). Depending on the moment that yor dependency was first | |
| the dependency use hooks). Depending on the moment that your dependency was first |
sgb-io
reviewed
Jun 28, 2022
sgb-io
reviewed
Jun 28, 2022
docs/esm-views/known-limitations.md
Outdated
| CDN). [It also provides `[selectiveCDNResolutions]`](./esm-cdn.md), a template | ||
| string to automatically translate | ||
| [Yarn selective version resolutions](https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/) | ||
| to lists of locked dependencies. |
There was a problem hiding this comment.
Would it possible to have an example for each solution for the same React 16.8/17 example you referred to above? But this time showing the Modular solutions
steveukx
reviewed
Jun 28, 2022
steveukx
reviewed
Jun 28, 2022
sgb-io
reviewed
Jun 28, 2022
| // Some CDNs support this mechanism - https://github.com/esm-dev/esm.sh#specify-external-dependencies | ||
| // This is especially useful if we have stateful dependencies (like React) that we need to query the same version through all our CDN depenencies | ||
| // We just output them as a comma-separated parameter in the CDN template as [selectiveCDNResolutions] | ||
| // TODO: possibly fallback to a filtered version of resolutions if this is not present |
There was a problem hiding this comment.
Do we want this TODO in the code?
There was a problem hiding this comment.
Removed, thanks!
sgb-io
previously approved these changes
Jun 28, 2022
Co-authored-by: Steve King <steve@mydev.co> Co-authored-by: Sam Brown <sam@sgb.io>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolutionsare formatted as a CSV in the[selectiveCDNResolutions]template field. Since external dependencies in esm.sh are a similar concept to selective dependencies resolutions in Yarn (they both lock a subdependency version through the whole dependency tree), it makes sense to have this courtesy template token.peerDependencyes resolution at CDN build time work and how the problem of multiple stateful dependencies is solved by the currently available CDNs.