Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Webpack 5 Asset Modules - PR for v3.0.1 #1734

Merged
merged 5 commits into from
May 17, 2022

Conversation

cristiano-belloni
Copy link
Contributor

@cristiano-belloni cristiano-belloni commented May 17, 2022

Original PR: #1707

cheemcheem and others added 2 commits May 17, 2022 15:37
* Move to Webpack 5 Asset Modules

* Add changeset

* Fix lint/prettier issues

* Fix snapshot

* Update more snapshots and test file hashes

* Update snapshots

* More snapshots etc

* Use asset instead of asset/resource

* Use CRA5 specific conf for svg

* Update node-env snapshots

* re-introduce imageInlineSizeLimit

Co-authored-by: Cristiano Belloni <cristiano.belloni@jpmorgan.com>
@changeset-bot
Copy link

changeset-bot bot commented May 17, 2022

🦋 Changeset detected

Latest commit: a78cd01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
modular-scripts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cristiano-belloni cristiano-belloni changed the title Feature/asset type wp5 Move to Webpack 5 Asset Modules - PR for v3.0.1 May 17, 2022
@coveralls
Copy link
Collaborator

coveralls commented May 17, 2022

Coverage Status

Coverage decreased (-26.5%) to 0.0% when pulling a78cd01 on feature/asset-type-wp5 into 6b98a4b on release/v3.0.1.

@cristiano-belloni cristiano-belloni merged commit 4c27c33 into release/v3.0.1 May 17, 2022
@cristiano-belloni cristiano-belloni deleted the feature/asset-type-wp5 branch May 17, 2022 16:08
@github-actions github-actions bot mentioned this pull request May 17, 2022
cristiano-belloni added a commit that referenced this pull request May 18, 2022
* Move to Webpack 5 Asset Modules - PR for v3.0.1 (#1734)

* Move to Webpack 5 Asset Modules (#1707)

* Move to Webpack 5 Asset Modules

* Add changeset

* Fix lint/prettier issues

* Fix snapshot

* Update more snapshots and test file hashes

* Update snapshots

* More snapshots etc

* Use asset instead of asset/resource

* Use CRA5 specific conf for svg

* Update node-env snapshots

* re-introduce imageInlineSizeLimit

Co-authored-by: Cristiano Belloni <cristiano.belloni@jpmorgan.com>

* Fix snapshots

* Correct snapshot case

* Remove NODE_ENV test

* Remove obsolete snap

Co-authored-by: Kathan Cheema <cheemcheem@users.noreply.github.com>

* Version Packages (#1735)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: Kathan Cheema <cheemcheem@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants