-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Webpack 5 Asset Modules - PR for v3.0.1 #1734
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move to Webpack 5 Asset Modules * Add changeset * Fix lint/prettier issues * Fix snapshot * Update more snapshots and test file hashes * Update snapshots * More snapshots etc * Use asset instead of asset/resource * Use CRA5 specific conf for svg * Update node-env snapshots * re-introduce imageInlineSizeLimit Co-authored-by: Cristiano Belloni <cristiano.belloni@jpmorgan.com>
🦋 Changeset detectedLatest commit: a78cd01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cristiano-belloni
changed the title
Feature/asset type wp5
Move to Webpack 5 Asset Modules - PR for v3.0.1
May 17, 2022
steveukx
approved these changes
May 17, 2022
Merged
cristiano-belloni
added a commit
that referenced
this pull request
May 18, 2022
* Move to Webpack 5 Asset Modules - PR for v3.0.1 (#1734) * Move to Webpack 5 Asset Modules (#1707) * Move to Webpack 5 Asset Modules * Add changeset * Fix lint/prettier issues * Fix snapshot * Update more snapshots and test file hashes * Update snapshots * More snapshots etc * Use asset instead of asset/resource * Use CRA5 specific conf for svg * Update node-env snapshots * re-introduce imageInlineSizeLimit Co-authored-by: Cristiano Belloni <cristiano.belloni@jpmorgan.com> * Fix snapshots * Correct snapshot case * Remove NODE_ENV test * Remove obsolete snap Co-authored-by: Kathan Cheema <cheemcheem@users.noreply.github.com> * Version Packages (#1735) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kathan Cheema <cheemcheem@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #1707