Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support node 16 explicitly and run test workflow against target node #1546

Merged
merged 16 commits into from
Apr 7, 2022
Merged

support node 16 explicitly and run test workflow against target node #1546

merged 16 commits into from
Apr 7, 2022

Conversation

LukeSheard
Copy link
Contributor

@LukeSheard LukeSheard commented Apr 6, 2022 •
edited
Loading

Updating the setup-node configuration so that the versions of node that we support are explictly coded in, this is because currently we're running a workflow with the latest node v.x version in a range, not the minimum version we support which leads to runtime differences.

cc. @steveukx / @cristiano-belloni

dependabot bot and others added 13 commits March 29, 2022 14:39
@dependabot @LukeSheard
Bump rollup from 2.67.2 to 2.70.1 (#1478)
bec55a5 
* Bump rollup from 2.67.2 to 2.70.1

Bumps [rollup](https://github.com/rollup/rollup) from 2.67.2 to 2.70.1.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.67.2...v2.70.1)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* update snapshots

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Luke Sheard <me@lukesheard.com>
@dependabot @LukeSheard
Bump commander from 8.2.0 to 9.1.0 (#1492)
810934b 
* Bump commander from 8.2.0 to 9.1.0

Bumps [commander](https://github.com/tj/commander.js) from 8.2.0 to 9.1.0.
- [Release notes](https://github.com/tj/commander.js/releases)
- [Changelog](https://github.com/tj/commander.js/blob/master/CHANGELOG.md)
- [Commits](tj/commander.js@v8.2.0...v9.1.0)

---
updated-dependencies:
- dependency-name: commander
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Create silent-donkeys-peel.md

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Luke Sheard <LukeSheard@users.noreply.github.com>
@dependabot
Bump @changesets/cli from 2.21.1 to 2.22.0 (#1516)
7ca3c81 
Bumps [@changesets/cli](https://github.com/changesets/changesets) from 2.21.1 to 2.22.0.
- [Release notes](https://github.com/changesets/changesets/releases)
- [Changelog](https://github.com/changesets/changesets/blob/main/docs/modifying-changelog-format.md)
- [Commits](https://github.com/changesets/changesets/compare/@changesets/cli@2.21.1...@changesets/cli@2.22.0)

---
updated-dependencies:
- dependency-name: "@changesets/cli"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@LukeSheard
Fix failing tests (#1543)
6bbc904
@dependabot
Bump eslint-plugin-import from 2.25.3 to 2.26.0 (#1541)
1ef86e4 
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.25.3 to 2.26.0.
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases)
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.25.3...v2.26.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-import
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump webpack-dev-server from 4.7.4 to 4.8.0 (#1542)
b074c03 
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server) from 4.7.4 to 4.8.0.
- [Release notes](https://github.com/webpack/webpack-dev-server/releases)
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md)
- [Commits](webpack/webpack-dev-server@v4.7.4...v4.8.0)

---
updated-dependencies:
- dependency-name: webpack-dev-server
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @changesets/changelog-github from 0.4.3 to 0.4.4 (#1515)
98861e4 
Bumps [@changesets/changelog-github](https://github.com/changesets/changesets) from 0.4.3 to 0.4.4.
- [Release notes](https://github.com/changesets/changesets/releases)
- [Changelog](https://github.com/changesets/changesets/blob/main/docs/modifying-changelog-format.md)
- [Commits](https://github.com/changesets/changesets/compare/@changesets/changelog-github@0.4.3...@changesets/changelog-github@0.4.4)

---
updated-dependencies:
- dependency-name: "@changesets/changelog-github"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @rollup/plugin-commonjs from 21.0.2 to 21.0.3 (#1511)
6ed036e 
Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs) from 21.0.2 to 21.0.3.
- [Release notes](https://github.com/rollup/plugins/releases)
- [Changelog](https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md)
- [Commits](https://github.com/rollup/plugins/commits/commonjs-v21.0.3/packages/commonjs)

---
updated-dependencies:
- dependency-name: "@rollup/plugin-commonjs"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @types/react from 17.0.42 to 17.0.43 (#1505)
d87a123 
Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 17.0.42 to 17.0.43.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump dotenv-expand from 8.0.2 to 8.0.3 (#1498)
d9aed5f 
Bumps [dotenv-expand](https://github.com/motdotla/dotenv-expand) from 8.0.2 to 8.0.3.
- [Release notes](https://github.com/motdotla/dotenv-expand/releases)
- [Changelog](https://github.com/motdotla/dotenv-expand/blob/master/CHANGELOG.md)
- [Commits](motdotla/dotenv-expand@v8.0.2...v8.0.3)

---
updated-dependencies:
- dependency-name: dotenv-expand
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/setup-node from 3.0.0 to 3.1.0 (#1532)
4e5c5a3 
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3.0.0...v3.1.0)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump micromatch from 4.0.4 to 4.0.5 (#1506)
f15e790 
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.4...4.0.5)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@LukeSheard
support node 16 explicitly and run test workflow against target node …
9f48679 
…versions
@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 8901b9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
create-modular-react-app Patch
modular-scripts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Apr 6, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 28.786% when pulling 8901b9f on bugfix/workflow-node-version into f15e790 on main.

cristiano-belloni
cristiano-belloni reviewed Apr 6, 2022
View reviewed changes
packages/modular-scripts/package.json Outdated
@@ -13,7 +13,7 @@
"./tsconfig.json": "./tsconfig.json"
},
"engines": {
"node": "^12.13.0 || ^14.15.0 || >=15.0.0"
"node": "^12.20.0 || ^14.15.0 || >=15.0.0 || >=16.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're updating the engines, wouldn't it be better to merge this in #1538 and have teams testing it in alpha for a while? I bet that some teams run node < 12.20, for example.

Copy link
Contributor Author

@LukeSheard LukeSheard Apr 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the original commit workflows here, installation fails for <12.20.0 unless --ignore-engines is already set because of the current find-up dependency. This was actually one of the reasons that I'm proposing this change to ensure that dependency upgrades also don't cause failures in the version of node we support.

In theory this release should be a no-op in a practical sense.

@cristiano-belloni cristiano-belloni changed the base branch from main to feature/node-12-remove-support April 7, 2022 10:42
@cristiano-belloni cristiano-belloni merged commit 0a0bc65 into feature/node-12-remove-support Apr 7, 2022
@cristiano-belloni cristiano-belloni deleted the bugfix/workflow-node-version branch April 7, 2022 10:58
@github-actions github-actions bot mentioned this pull request Apr 7, 2022
Merged
@LukeSheard LukeSheard restored the bugfix/workflow-node-version branch April 7, 2022 13:22
@LukeSheard LukeSheard deleted the bugfix/workflow-node-version branch April 12, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiano-belloni cristiano-belloni cristiano-belloni left review comments

@benpryke benpryke Awaiting requested review from benpryke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukeSheard @coveralls @cristiano-belloni