Bump Typescript, @typescript-eslint, eslint-plugin-jest, eslint-plugin-testing-library and update tests and definitions #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0ea7cb7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@cristiano-belloni what's the resolution plan for this? Was this resolved with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #1186 and #1166
This PR originated from a bug noticed by @cangarugula, where our Typescript svg definitions were not working. I discovered that the problem happens only with
typescript@>4.5.0 <=4.5.2. Additionally, I discovered that the tilde definition of our typescript dependency conflicts with@typescript-eslint(yarn lintprinting warnings), now that4.5is out.There are two possible ways of fixing this: the easy one is constricting our
typescriptdependency to be strictly less than4.5.0and dealing with excluding the faulty versions later (https://github.com/jpmorganchase/modular/pull/1166/files). The longer one is to upgrade typescript, force it to be greater or equal to than4.5.3to exclude the faulty versions and update all the incompatible dependencies (this PR).This PR updates:
@typescript-eslintto the latest version + fixes manyanydefinitions that are not allowed any moreeslint-plugin-jest, eslint-plugin-testing-libraryto the latest version + fixes test expectations to align with it (egtoEqualbecomestoBeetc)This is breaking, since we're bumping
modular-scriptsto use a stricter linter that can break builds and tests.