Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esbuild improvements #1113

Merged
merged 13 commits into from
Dec 2, 2021
Merged

Esbuild improvements #1113

merged 13 commits into from
Dec 2, 2021

Conversation

LukeSheard
Copy link
Contributor

@LukeSheard LukeSheard commented Nov 29, 2021

Screenshot 2021-11-29 at 23 02 40

Beginning of a serious tidy up focussing on bringing consistency to the webpack and esbuild experiences.

  1. Fixes for sourcemaps to generate sourcemaps which represent state from the modular root instead of the app root.
  2. Improves experience of the error overlay to at least show state within the modular repo instead of relative to the app source to deal with cross package errors
  3. Output in source tree is now shown relative to the page root.
  4. Moved plugins to be co-located with APIs which require them.
  5. start is now entirely in-memory reducing footprint onto disk.
  6. Cleaned up metafile output to be relative to modular root which improves clean-ness of API interaction.
  7. 'moves' CSS file generation to be in /static/css/* instead of /static/js
  8. modular build now produces hashed asset names for cache busting via esbuild hashing API.

Screenshot 2021-11-29 at 23 05 26

@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2021

🦋 Changeset detected

Latest commit: eb49b93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
modular-scripts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Dec 1, 2021

Coverage Status

Coverage decreased (-0.8%) to 29.137% when pulling eb49b93 on feature/asset-names into 5954fe6 on main.

Copy link
Contributor

@cristiano-belloni cristiano-belloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and very fast (I tried it). For the future, would it be worth to have an (hidden?) switch to dump the metafile somewhere? I was looking at it and it seems very useful to debug a build.

@LukeSheard
Copy link
Contributor Author

@cristiano-belloni We'll need to expose it for the future in some form and generate an asset-manifest.json file similar to webpack, but we could also just have a flag for it as well.

@cristiano-belloni cristiano-belloni self-requested a review December 2, 2021 11:12
@LukeSheard LukeSheard merged commit ee44098 into main Dec 2, 2021
@LukeSheard LukeSheard deleted the feature/asset-names branch December 2, 2021 11:17
@github-actions github-actions bot mentioned this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants