Refactor

jpmorganchase · Apr 27, 2023 · 0c433d9 · 0c433d9
1 parent c675f8e
commit 0c433d9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/packages/modular-scripts/src/build-scripts/build-package/makeBundle.ts b/packages/modular-scripts/src/build-scripts/build-package/makeBundle.ts
@@ -39,7 +39,6 @@ export async function makeBundle(
   const {
     rootPackageWorkspaceDefinitions,
     rootPackageJsonDependencies,
-    rootPackageJsonEngines,
     packageJsons,
     packageJsonsByPackagePath,
     packageNames,
@@ -57,11 +56,6 @@ export async function makeBundle(
 
   const packageJson = packageJsonsByPackagePath[packagePath];
 
-  // If engines field is not defined in the package's package.json, inherit it from the root package.json
-  if (!packageJson.engines) {
-    packageJson.engines = rootPackageJsonEngines;
-  }
-
   const main = await getPackageEntryPoints(packagePath, includePrivate);
 
   logger.log(`building ${packageName}...`);

diff --git a/packages/modular-scripts/src/utils/getPackageMetadata.ts b/packages/modular-scripts/src/utils/getPackageMetadata.ts
@@ -48,6 +48,10 @@ async function getPackageMetadata() {
 
   Array.from(workspaces).forEach(([packageName, workspace]) => {
     packageJsons[packageName] = workspace.rawPackageJson;
+    if (!packageJsons[packageName].engines) {
+      // If engines field is not defined in the package's package.json, inherit it from the root package.json
+      packageJsons[packageName].engines = rootPackageJsonEngines;
+    }
     packageJsonsByPackagePath[workspace.location] = workspace.rawPackageJson;
   });