Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate python coverage report. #17

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

ceball
Copy link
Contributor

@ceball ceball commented Apr 16, 2020

Coverage is missing; shield shows 0% on github, and there's a warning during the build:

Screenshot from 2020-04-16 16-25-14

Not sure if you want to generate a coverage report every time you do make testpy? If not, let me know what you prefer.

@ceball
Copy link
Contributor Author

ceball commented Apr 16, 2020

Looks like coverage worked for this PR:

cov

@timkpaine
Copy link
Collaborator

@sc1f this might be helpful for the issues you saw in finos/perspective#1010

@timkpaine timkpaine self-requested a review April 16, 2020 16:12
@timkpaine timkpaine merged commit b781f70 into jpmorganchase:master Apr 16, 2020
@telamonian telamonian added this to the 0.0.2 milestone May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants