Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block playlist remove for animations #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pdf
Copy link

@pdf pdf commented Apr 2, 2013

Blocking removes for animations makes for plenty of headaches and timing
shenanigans. Let's not do that.

Instead, store a reference to the generated element on the playlist and
original arrays and use that as the selector for removal and highlighting.

@pdf
Copy link
Author

pdf commented Apr 2, 2013

I also have insert() and replace() methods ready to pull in a subsequent commit (9029f78), but it's based on this PR because it relies on the new _element property (and it helps if remove() doesn't suck).

My insert() method probably makes #102 obsolete, since insert() is more functional (insert at any position, versus just prepending).

@pdf
Copy link
Author

pdf commented Apr 2, 2013

Updated the PR to tidy up a little and fix a bug on refresh. The _element property is now initialized in _initPlaylist(), and re-used everywhere.

Blocking removes for animations makes for plenty of headaches and timing
shenanigans.  Let's not do that.

Instead, store a reference to the generated element on the playlist and
original arrays and use that as the selector for removal and
highlighting.
@pdf
Copy link
Author

pdf commented Apr 23, 2013

Rebased against master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant