Introduce empty_as_none and empty_as_none_vec deserializers
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jplatte I've kept this as a draft PR since it does not contain documentation yet, but I'm curious whether you think this is a direction worth continuing :) |
This commit changes the way `foo=` is deserialized into `Option<_>`. Previously it was deserialized as `None`, now it will be deserialized as `Some(_)`, unless the new `empty_as_none` deserializer is used via `#[serde(deserialize_with = "crate::de::empty_as_none")]`. This allows users to decide on the deserialization strategy on a field-by-field basis.
7bc9bd3 to
8960c9d
Compare
|
any more thoughts on this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the way
foo=is deserialized intoOption<_>. Previously it was deserialized asNone, now it will be deserialized asSome(_), unless the newempty_as_nonedeserializer is used via#[serde(deserialize_with = "crate::de::empty_as_none")]. This allows users to decide on the deserialization strategy on a field-by-field basis.Resolves #13