Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve resolveWith #78

Closed
jackmellis opened this issue Aug 20, 2020 · 2 comments
Closed

improve resolveWith #78

jackmellis opened this issue Aug 20, 2020 · 2 comments
Labels
breaking enhancement released
Milestone
major (v4.0.0)

Comments

@jackmellis
Copy link
Member

The current syntax for resolve with is pretty bad:

jpex.resolveWith<Foo>({
  [jpex.infer<Bah>()]: 'bah',
  [jpex.infer<Baz>()]: 'baz',
})

but how can we make it better?
@jackmellis jackmellis added this to the major (v4.0.0) milestone Aug 20, 2020
@jackmellis
Copy link
Member Author 

jpex.resolveWith<Foo, Bah, Baz>([ 'bah', 'baz' ]);

could be the best option...

jackmellis pushed a commit that referenced this issue Aug 23, 2020
feat: nicer syntax for resolveWith
5348bba 
closes #78
jackmellis pushed a commit that referenced this issue Aug 23, 2020
feat: nicer syntax for resolveWith
3b14d4e 
closes #78
jackmellis pushed a commit that referenced this issue Aug 24, 2020
feat: nicer syntax for resolveWith
d2ec9b2 
closes #78
jackmellis pushed a commit that referenced this issue Aug 27, 2020
feat: nicer syntax for resolveWith
5252a22 
closes #78
jackmellis pushed a commit that referenced this issue Sep 25, 2020
@jackmellis
feat: nicer syntax for resolveWith
2489926 
closes #78
@jackmellis
Copy link
Member Author

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking enhancement released
Projects
None yet
Milestone
major (v4.0.0)
Development

No branches or pull requests
1 participant
@jackmellis