Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Globals #69

Closed
jackmellis opened this issue Jul 27, 2020 · 1 comment
Closed

Globals #69

jackmellis opened this issue Jul 27, 2020 · 1 comment
Labels
breaking enhancement released
Milestone
major (v4.0.0)

Comments

@jackmellis
Copy link
Member

jackmellis commented Jul 27, 2020 •
edited
Loading

It’d be nice if you could resolve global variables like window automatically.

So if a factory doesn’t exist, check if it exists on the global scope

This is potentially breaking as stuff that would fall over before for not existing, could now be resolved on the global object. This might not be a problem, per se, but it is a change to expected behaviour.
@jackmellis jackmellis added this to the major milestone Jul 27, 2020
jackmellis pushed a commit that referenced this issue Aug 17, 2020
feat: auto resolve globals
3a36977 
global dependencies such as `Window` and `Document` are now automatically resolved (unless you register your own dependency of the same name)

closes #69
jackmellis pushed a commit that referenced this issue Aug 24, 2020
feat: auto resolve globals
72bec4c 
global dependencies such as `Window` and `Document` are now automatically resolved (unless you register your own dependency of the same name)

closes #69
jackmellis pushed a commit that referenced this issue Aug 27, 2020
feat: auto resolve globals
2a756c6 
global dependencies such as `Window` and `Document` are now automatically resolved (unless you register your own dependency of the same name)

closes #69
jackmellis pushed a commit that referenced this issue Sep 25, 2020
@jackmellis
feat: auto resolve globals
8c01223 
global dependencies such as `Window` and `Document` are now automatically resolved (unless you register your own dependency of the same name)

closes #69
@jackmellis
Copy link
Member Author

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking enhancement released
Projects
None yet
Milestone
major (v4.0.0)
Development

No branches or pull requests
1 participant
@jackmellis