Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when share box is hidden. #8

Closed
Relin opened this issue Jul 30, 2020 · 1 comment
Closed

Error when share box is hidden. #8

Relin opened this issue Jul 30, 2020 · 1 comment
Assignees

Comments

@Relin
Copy link

Relin commented Jul 30, 2020

Hi,
I encounter an error when the mouse leave the node.
After looking the code, I expect it's due to:
src/js/event/behavior.js

         this.$image.on('mouseleave', function() {
            const $elements = $(this).find('.hotspot, .item');
            $.each($elements, function() {
                DomHelper.hideElement($(this)[0]);
            });

            const $shareBox = $(this).find('.social-share-box');
            DomHelper.hideElement($shareBox[0]);
        });

Especially this line DomHelper.hideElement($shareBox[0]); where $shareBox can be empty if we use the option to hide the sharing box.

@jpchateau jpchateau self-assigned this Jul 31, 2020
@jpchateau
Copy link
Owner

Hi @Relin !

I just released a fix for this issue. Check for version 2.7.1.
Thank you for having reported this issue and for bringing help to solve it!

@Relin Relin closed this as completed Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants