Merge pull request #128 from jparkerweb/develop

v2.20.1
jparkerweb · Jan 17, 2025 · cf48dc7 · cf48dc7
2 parents a747d60 + c616523
commit cf48dc7
Show file tree

Hide file tree

Showing 18 changed files with 644 additions and 134 deletions.
diff --git a/.vault/pixel-banner-example/.obsidian/plugins/pexels-banner/data.json b/.vault/pixel-banner-example/.obsidian/plugins/pexels-banner/data.json
@@ -128,11 +128,11 @@
   "showPinIcon": true,
   "pinnedImageFolder": "pixel-banner-images",
   "showReleaseNotes": true,
-  "lastVersion": "2.19.2",
+  "lastVersion": "2.20.0",
   "showRefreshIcon": true,
   "showViewImageIcon": true,
-  "hidePixelBannerFields": true,
-  "hidePropertiesSectionIfOnlyBanner": true,
+  "hidePixelBannerFields": false,
+  "hidePropertiesSectionIfOnlyBanner": false,
   "titleColor": "var(--inline-title-color)",
   "enableImageShuffle": false,
   "hideEmbeddedNoteTitles": true,

diff --git a/.vault/pixel-banner-example/.obsidian/plugins/pexels-banner/main.js b/.vault/pixel-banner-example/.obsidian/plugins/pexels-banner/main.js
diff --git a/.vault/pixel-banner-example/.obsidian/plugins/pexels-banner/manifest.json b/.vault/pixel-banner-example/.obsidian/plugins/pexels-banner/manifest.json
@@ -1,7 +1,7 @@
 {
     "id": "pexels-banner",
     "name": "Pixel Banner",
-    "version": "2.20.0",
+    "version": "2.20.1",
     "minAppVersion": "1.6.0",
     "description": "Apply an image from various sources as a banner to your notes.",
     "author": "Justin Parker (eQui\\\\ Labs)",

diff --git a/.vault/pixel-banner-example/.obsidian/plugins/pexels-banner/styles.css b/.vault/pixel-banner-example/.obsidian/plugins/pexels-banner/styles.css
@@ -669,8 +669,10 @@
     white-space: nowrap;
     color: var(--pixel-banner-icon-color, var(--text-normal));
     background: var(--pixel-banner-icon-background-color, unset);
-    padding: var(--pixel-banner-icon-padding, 0);
-    padding-top: var(--pixel-banner-icon-padding, 0) !important;
+    padding-top: var(--pixel-banner-icon-padding-y, 0) !important;
+    padding-right: var(--pixel-banner-icon-padding-x, 0) !important;
+    padding-bottom: var(--pixel-banner-icon-padding-y, 0) !important;
+    padding-left: var(--pixel-banner-icon-padding-x, 0) !important;
     border-radius: var(--pixel-banner-icon-border-radius, 17px);
     margin-top: var(--pixel-banner-icon-vertical-offset, 0);
 }
diff --git a/.vault/pixel-banner-example/.obsidian/workspace.json b/.vault/pixel-banner-example/.obsidian/workspace.json
@@ -22,17 +22,17 @@
             }
           },
           {
-            "id": "dd6ed41c28754b26",
+            "id": "335afda63a567fc7",
             "type": "leaf",
             "state": {
-              "type": "webviewer",
+              "type": "markdown",
               "state": {
-                "url": "https://jparkerweb.github.io/release-notes/",
-                "title": "Release Notes Generator",
-                "mode": "webview"
+                "file": "tests/banner icon 2.md",
+                "mode": "preview",
+                "source": true
               },
-              "icon": "globe-2",
-              "title": "Release Notes Generator"
+              "icon": "lucide-file",
+              "title": "banner icon 2"
             }
           }
         ]
@@ -3108,6 +3108,256 @@
           {
             "id": "1fbe78b06b0c558b",
             "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "b02f7c1318be2e85",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "fd63bb1e450c47f7",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "989ded75d35bfad1",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "1906e95e8dae1df9",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "9017040a28fc9e77",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "155b153251d3838b",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "02e02686276f027f",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "3e977ca6f7a9fd8b",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "04ea30e8cff24a66",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "7a08ab0bc0f26921",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "8bb6e1e42be410b1",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "f267dbdf3dbe8aec",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "4678c72a56b40d59",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "7a2ab7ea5561d68e",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "621ffd2c0a8c7956",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "cd8608d37e711b01",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "2ae5f94d206e5bda",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "0fa254a18299ce1f",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "4d1893f7a322f629",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "d087a374eb1e8eab",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "1d6058e19553b9aa",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "00acac27f2b7f2d2",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "d1eb3875920a06f4",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "03c7004c9b8b3233",
+            "type": "leaf",
+            "state": {
+              "type": "empty",
+              "state": {},
+              "icon": "lucide-file",
+              "title": "New tab"
+            }
+          },
+          {
+            "id": "ceac080a7944112c",
+            "type": "leaf",
             "state": {
               "type": "Saved Queries View",
               "state": {},
@@ -3116,7 +3366,7 @@
             }
           }
         ],
-        "currentTab": 298
+        "currentTab": 323
       }
     ],
     "direction": "horizontal",
@@ -3135,13 +3385,13 @@
   },
   "active": "fc67a63095b6a8e2",
   "lastOpenFiles": [
+    "tests/banner icon 2.md",
+    "tests/banner icon 1.md",
     "🚩 Pixel-Banner.md",
     "releases/v2.20.0 - ⭐ The Icon has Landed.md",
-    "tests/banner icon.md",
     "tests/🧪 test - 10 - embed tests.md",
     "banner icon test.md",
     "pow.md",
-    "Untitled.md",
     "Untitled 1.md",
     "releases/v2.19.0 - 🦜 X Marks the Spot.md",
     "pixel-banner-images/shooting-star.png",

diff --git a/...pixel-banner-example/tests/banner icon.md → ...xel-banner-example/tests/banner icon 1.md b/...pixel-banner-example/tests/banner icon.md → ...xel-banner-example/tests/banner icon 1.md
@@ -6,7 +6,8 @@ content-start: 400
 icon-color: papayawhip
 icon-size: "34"
 icon-bg-color: "#2c2d9d80"
-icon-padding: "10"
+icon-padding-x: "20"
+icon-padding-y: "15"
 icon-border-radius: "50"
 ---
 
diff --git a/.vault/pixel-banner-example/tests/banner icon 2.md b/.vault/pixel-banner-example/tests/banner icon 2.md
@@ -0,0 +1,13 @@
+---
+banner: "[[shooting-star.png]]"
+content-start: 360
+icon: v2.20.0 - ⭐ The Icon has Landed
+icon-size: "30"
+icon-x: "50"
+icon-y: "-20"
+icon-bg-color: "#00000070"
+icon-padding-x: "100"
+icon-padding-y: "20"
+---
+
+Example `banner icon` in a note ⭐
diff --git a/.vault/pixel-banner-example/🚩 Pixel-Banner.md b/.vault/pixel-banner-example/🚩 Pixel-Banner.md
@@ -1,6 +1,8 @@
 ---
 banner: "[[forest.jpg]]"
 content-start: 350
+icon: 🌲
+icon-size: "100"
 ---
 # 🚩 Pixel-Banner 
 🐙 [GitHub](https://github.com/jparkerweb/pixel-banner)

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,14 @@
 
 All notable changes to the Pixel Banner plugin will be documented in this file.
 
+### [v2.20.1] - 2025-01-17
+#### 📦 Updated
+- replaced `icon-padding` with `icon-padding-x` and `icon-padding-y` for more granular control
+
+#### 🐛 Fixed
+- resolved issue with the banner updating while editing a note's content (causing the banner to flicker)
+- resolved issue with the banner icon not being preserved when scrolling to the bottom of a note
+
 ### [v2.20.0] - 2025-01-16
 #### ✨ Added the highly requested feature: `Banner Icons`!
 - Add emoji overlays (⭐, 🎨, 📝, etc.) to your banners