Skip to content
This repository has been archived by the owner on Oct 3, 2018. It is now read-only.

Added some tests for Node #59

Merged
merged 3 commits into from
Sep 23, 2014
Merged

Added some tests for Node #59

merged 3 commits into from
Sep 23, 2014

Conversation

adam-lynch
Copy link
Contributor

These will fail right now but pass once #58 is merged.

@adam-lynch
Copy link
Contributor Author

Don't merge yet. Gotta get npm test to reach into node_modules & call Grunt, instead of requiring grunt-cli to be installed.

@adam-lynch
Copy link
Contributor Author

Ok, this is ready for merging (still will fail unless #58 is merged though).

Note: now grunt-cli needs to be installed globally to run the tests. There's no way to reach into node_modules like I said (which will work on all platforms). The Travis build will now install grunt-cli before running the tests.

This was referenced Sep 22, 2014
@hassankhan
Copy link
Contributor

I think the tests are still failing:

�[0K$ npm test

> emojify.js@0.9.4 test /home/travis/build/hassankhan/emojify.js
> grunt test-node && phantomjs phantom.js

�[4mRunning "mochaTest:test" (mochaTest) task�[24m

�[0m�[0m
�[0m  emojify in a Node environment�[0m
�[0m    .replace�[0m
�[2K�[0G    �[31m  1) "before each" hook�[0m


�[92m �[0m�[32m 0 passing�[0m�[90m (6ms)�[0m
�[31m  1 failing�[0m

�[0m  1) emojify in a Node environment "before each" hook:
�[0m�[31m     ReferenceError: window is not defined�[0m�[90m
      at /home/travis/build/hassankhan/emojify.js/emojify.js:19:28
      at /home/travis/build/hassankhan/emojify.js/emojify.js:302:11
      at document (/home/travis/build/hassankhan/emojify.js/emojify.js:9:26)
      at Object.<anonymous> (/home/travis/build/hassankhan/emojify.js/emojify.js:14:2)
      at Module._compile (module.js:456:26)
      at Object.Module._extensions..js (module.js:474:10)
      at Module.load (module.js:356:32)
      at Function.Module._load (module.js:312:12)
      at Module.require (module.js:364:17)
      at require (module.js:380:17)
�[0m


�[33mWarning: Task "mochaTest:test" failed.� Use --force to continue.�[39m

�[31mAborted due to warnings.�[39m
�[37m�[40mnpm�[0m �[0m�[31m�[40mERR!�[0m�[35m�[0m Test failed.  See above for more details.
�[0m�[37m�[40mnpm�[0m �[0m�[31m�[40mERR!�[0m �[0m�[35mnot ok�[0m code 0
�[0mtravis_time:end:10161195:start=1411419501247976292,finish=1411419502519079284,duration=1271102992
�[0K
�[31;1mThe command "npm test" exited with 1.�[0m

Done. Your build exited with 1.

@adam-lynch
Copy link
Contributor Author

That's because you merged the fix but I haven't pull that change down onto my fork's branch. Will do there in a minute.

@adam-lynch
Copy link
Contributor Author

Tada ^

@hassankhan
Copy link
Contributor

I would've thought the pull request branch on Travis-CI would run against master on the repo, not your fork. Oh well, thanks for sorting that out 👍

hassankhan added a commit that referenced this pull request Sep 23, 2014
@hassankhan hassankhan merged commit 94e5979 into joypixels:master Sep 23, 2014
@adam-lynch adam-lynch deleted the node-tests branch September 23, 2014 10:49
@adam-lynch
Copy link
Contributor Author

Maybe it would if there wasn't merge conflict

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants