added LinkType.Top enum, so we can specify only top level links #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (_resource.LinkType.HasFlag(LinkType.Self)) | ||
| // if resource has Top only and not Self, then we render it. | ||
| // otherwise to preserve back compatibility if Self is enabled, then we also render it | ||
| if ((_resource.LinkType.HasFlag(LinkType.Top) && !_resource.LinkType.HasFlag(LinkType.Self)) |
There was a problem hiding this comment.
I think this can be simplified to Top || Self?
There was a problem hiding this comment.
Agree. Updated it
Saule/LinkType.cs
Outdated
| /// <summary> | ||
| /// Only top section links | ||
| /// </summary> | ||
| Top = 4, |
There was a problem hiding this comment.
Like I said on the issue, should this contain the word Self since it only applies to that?
There was a problem hiding this comment.
Updated it. Now it's TopSelf
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jouke,
It's a PR for #201 item. I tried to preserve back compatibility and all existing tests are passing fine. I also added new one to test Top only scenario.
Thanks