configureJsonApi overload (formatter can be only add at end of the collection, without delete other formatters #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joukevandermaas
requested changes
Aug 2, 2017
Saule/ConfigureFormattersEnum.cs
Outdated
| /// <summary> | ||
| /// Configuration enum for formatters | ||
| /// </summary> | ||
| public enum ConfigureFormattersEnum |
Saule/ConfigureFormattersEnum.cs
Outdated
| namespace Saule | ||
| { | ||
| /// <summary> | ||
| /// Configuration enum for formatters |
There was a problem hiding this comment.
This description isn't very clear. Maybe describe the purpose rather than what it does?
Saule/Http/HttpConfigExtensions.cs
Outdated
| /// <param name="config">The <see cref="HttpConfiguration"/> that is used in the setup of the application.</param> | ||
| /// <param name="jsonApiConfiguration">Configuration parameters for Json Api serialization.</param> | ||
| /// <param name="configureFormatters"> | ||
| /// AddFormatterToStart - Formatter will be inserted at the start of the collection. |
There was a problem hiding this comment.
This should be pretty clear from the enum values; maybe something like Determines the relative position of the JSON API formatter?
joukevandermaas
approved these changes
Aug 2, 2017
|
Thanks for this! I will publish a pre-release shortly with these changes in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added more options for configure formatters in ConfigureJsonApi. For example if want combinate JSON API with WebAPI together.
#167