This repository has been archived by the owner on Jun 17, 2021. It is now read-only.
Fix migration test on Windows #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWolf81
commented
Sep 7, 2018
| jest.mock('path', () => ({ | ||
| join: () => 'test/guppy-projects', | ||
| })); | ||
|
|
||
| const ENGINE_KEY = 'test-key'; |
There was a problem hiding this comment.
ENGINE_KEY seems unused as ESLint reported.
Should we remove it?
There was a problem hiding this comment.
Yeah, I believe I removed this in one of my PRs. Feel free to remove as well :)
kerm1it
approved these changes
Sep 7, 2018
joshwcomeau
approved these changes
Sep 7, 2018
| jest.mock('path', () => ({ | ||
| join: () => 'test/guppy-projects', | ||
| })); | ||
|
|
||
| const ENGINE_KEY = 'test-key'; |
There was a problem hiding this comment.
Yeah, I believe I removed this in one of my PRs. Feel free to remove as well :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue / PR
#70
Summary:
During my work on codecov CI I noticed that
migrations.testfailed if I runyarn teston Windows.Path.joinreturns a backslash on Windows. That's why I added a mock to it so it's returning the expected path.