Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/46 51 unified #54

Merged
merged 71 commits into from
Feb 9, 2022
Merged

Feature/46 51 unified #54

merged 71 commits into from
Feb 9, 2022

Conversation

joshuamkite
Copy link
Owner

@joshuamkite joshuamkite commented Feb 8, 2022 •
edited
Loading

7.0

Breaking changes with existing deployments using earlier module versions

  • Change: Retire deprecated null-resource provider
  • Change: Retire deprecated template provider (required for darwin_arm64). Fixes Issue #51
  • Feature: Support provider default tags as well as explicit tags for all supported resources plus autoscaling group
  • Change: Update Terraform version to >/=0.15.x/1.0.0
  • Change/Feature: Change from Launch Configuration to Launch Template. Includes support for spot instances. Fixes Issue #46
  • Feature: Enable setting cloudwatch metrics for autoscaling group
  • Feature: Add unique target group name for bastion host elb
  • Feature: Enable setting EBS size and name for bastion instance
  • Bugfix: Update formatting in readme
  • Bugfix: Spellcheck readme and changelog
  • Change: Update terraform-docs outputs on documentation
  • Change: Update internal filenames and references to comply with upstream template file naming conventions; move locals to locals.tf

hexionas and others added 30 commits June 17, 2019 14:30
@hexionas
Merge pull request #2 from getndazn/feature/sync-with-upstream
c366c67 
Feature/sync with upstream
@carvalho-dazn
PLAT-1652: Move bastions to use spot instances (#3)
37f13e2
@simonkey007
Add unique target group name for bastion host elb
1b7fbb2
@simonkey007
Merge pull request #5 from getndazn/PLAT-3903/rds_proxy_accessible_th…
7434c78 
…rough_bastions

Add unique target group name for bastion host elb
Use iam_instance_profile as block, not argument
316033e
Merge pull request #8 from getndazn/fix-launch-profile
743c05e 
Use iam_instance_profile as block, not argument
Add tags to aws_launch_template
f4ca781
Fix aws_launch_template
5b060d6 
use base64 for userdata template
use names for iam_instance_profile instead of arns
Fix aws_autoscaling_group - remove doubled $ from version
d0dfbd4
Merge pull request #9 from getndazn/fix-launch-template
97c95c4 
Fix launch template
Remove hardcoded intance types from ASG
70394c1
Merge pull request #10 from getndazn/instance-types
0930d52 
Remove hardcoded intance types from ASG
Add name tag to instance tags for launch template
fb410ab
Merge pull request #11 from getndazn/name-tag
7438646 
Add name tag to instance tags for launch template
Delete network interface on instance termination
5087116
Merge pull request #12 from getndazn/delete-on-termination
686f006 
Delete network interface on instance termination
Enable metrics collection on ASG
034d800
Merge pull request #13 from getndazn/PLAT-4675/logs+metrics
b20f4c3 
Enable metrics collection on ASG
Allow instances to kill themselves via ASG custom health check
3a55d5a
Merge pull request #14 from getndazn/PLAT-4678/perms-for-set-instance…
7d854d0 
…-health

Allow instances to kill themselves via ASG custom health check
Enable setting EBS size for bastion instance
2ef9e82
Merge pull request #15 from getndazn/ebs-size
22ca205 
Enable setting EBS size for bastion instance
Fix default name for ebs device
3de07dc
Merge pull request #16 from getndazn/ebs-device-name
e4fb0fb 
 Fix default name for ebs device
Change names for LB,launch_template,target_group,ASG
3ca77ac
Merge pull request #17 from getndazn/names-changes
06f84a0 
Change names for LB,launch_template,target_group,ASG
Fix name for target group
2d917d2
Merge pull request #18 from getndazn/tg-name-fix
460345e 
Fix name for target group
experimental conditional output
f713d4e
@joshuamkite
WIP working to move away from template_file
d2cb2e0
joshuamkite and others added 24 commits January 27, 2022 17:10
@joshuamkite
restore dazn launch template tags
07cf1fd
@joshuamkite
experimental conditional output
3694ded
@joshuamkite
WIP working to move away from template_file
6a4a0bd
@joshuamkite
WIP initial subsititution for template_file userdata
3e295b4
@joshuamkite
use bools once not comapre comparaitors
447ac24
@joshuamkite
move all template tp template_file
6f0a60a
@joshuamkite
initial working version with no template provider
f92312f
@joshuamkite
remove use of null provider and implement/enable provider default tag…
2b0518a 
…ging
@joshuamkite
restore formatting after reflow
a273410
@joshuamkite
formatting; spelling
ad229d1
@joshuamkite
remove redundant provider spec
ac1b840
@joshuamkite
remove redundany file
ac1fb16
@joshuamkite
terraform version
b2025b3
@joshuamkite
update changelog
8a466b6
@joshuamkite
readme: formatting; user data sectino
6924203
@joshuamkite
merge conflicts
89e25d8
@joshuamkite
revert inapproriate merge
f75938d
@joshuamkite
Merge branch 'feature/46_51_unified' into issue_51/template_file
fdc5299
@joshuamkite
Merge pull request #53 from joshuamkite/issue_51/template_file
9560240 
Issue 51/template file
@joshuamkite
debug and polish for release 7.0
e6ed993
@joshuamkite
Merge branch 'feature/46_51_unified' of github.com:joshuamkite/terraf…
c8a4193 
…orm-aws-ssh-bastion-service into feature/46_51_unified
@joshuamkite
remove asg health suicide permissions as no use case case described i…
44b8b26 
…n fork
@joshuamkite
restore examples/full.../main.tf
4b91a51
@joshuamkite
update changelog
9946874
@joshuamkite joshuamkite self-assigned this Feb 8, 2022
@joshuamkite joshuamkite merged commit fb96dc7 into master Feb 9, 2022
@joshuamkite joshuamkite deleted the feature/46_51_unified branch February 9, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshuamkite joshuamkite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

https://registry.terraform.io/providers/hashicorp/template/ is deprecated, and prevents usage on OSX
4 participants
@joshuamkite @hexionas @carvalho-dazn @simonkey007