fix(autocommands): Correct column preservation behavior in TWDisable #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmand - Added logic to check if column preservation is active when running the TWDisable command. - Reset column preservation state to NORMAL to ensure proper behavior when disabling typewriter mode. - Cleared relevant autocmds related to column preservation and cursor movement (CursorMoved event). - This ensures that after TWDisable is run, the column remains unmodified and behaves as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses an issue where the TWDisable command failed to fully disable column preservation, leading to unintended modifications of the cursor column after running the command. This fix ensures that the autocmd responsible for column preservation is correctly cleared when TWDisable is executed.
Changes:
Added a check within TWDisable to detect if column preservation is active and reset the state to NORMAL.
Included logic to clear any CursorMoved autocmds that might interfere with cursor behavior after disabling typewriter mode.
Provided feedback through a message indicating that column preservation has been disabled.
Testing:
Tested the TWDisable command to verify that column preservation is fully deactivated after use.
Ensured that all related autocmds are cleared, and the cursor behaves as expected without column modifications.
Related Issues:
Resolves Issue #20: TWDisable doesn’t disable the autocmd that modifies the column.