Merge pull request open-telemetry#1 from joshleecreates/ffs.add_proba…

…bility_based_flags

Add help text for float feature flags; Fix postgres upgrades

src/featureflagservice/lib/featureflagservice_web/templates/feature_flag/form.html.heex

@@ -30,10 +30,8 @@
   <%= error_tag f, :description %>
 
   <%= label f, :enabled %>
-  <div style="font-size:smaller; margin:-5px 0 3px 0">
-    0 = false. 1 = true. Values between 0 and 1 are treated as a random probability.
-  </div>
-  <%= text_input f, :enabled  %>
+  <%= number_input f, :enabled, min: 0, max: 1, step: 0.1, "aria-describedby": "enabled_help_text" %>
+  <p id="enabled_help_text">A value between 0.0 and 1.0. 0.0 is always disabled, 1.0 is always enabled, and all values between set a percentage chance on each request.</p>
   <%= error_tag f, :enabled %>
 
   <%= submit "Save" %>

src/featureflagservice/priv/repo/migrations/20220524172636_create_featureflags.exs

@@ -1,13 +1,11 @@
-
-
 defmodule Featureflagservice.Repo.Migrations.CreateFeatureflags do
   use Ecto.Migration
 
   def change do
     create table(:featureflags) do
       add :name, :string
       add :description, :string
-      add :enabled, :float, default: 0, null: false
+      add :enabled, :boolean, default: false, null: false
 
       timestamps()
     end
@@ -21,22 +19,26 @@ defmodule Featureflagservice.Repo.Migrations.CreateFeatureflags do
     repo().insert(%Featureflagservice.FeatureFlags.FeatureFlag{
       name: "productCatalogFailure",
       description: "Fail product catalog service on a specific product",
-      enabled: 0.0})
+      enabled: false
+    })
 
     repo().insert(%Featureflagservice.FeatureFlags.FeatureFlag{
       name: "recommendationCache",
       description: "Cache recommendations",
-      enabled: 0.0})
+      enabled: false
+    })
 
     repo().insert(%Featureflagservice.FeatureFlags.FeatureFlag{
       name: "adServiceFailure",
       description: "Fail ad service requests sporadically",
-      enabled: 0.0})
+      enabled: false
+    })
 
     repo().insert(%Featureflagservice.FeatureFlags.FeatureFlag{
       name: "cartServiceFailure",
       description: "Fail cart service requests sporadically",
-      enabled: 0.0})
+      enabled: false
+    })
   end
 
   defp execute_down do

src/featureflagservice/priv/repo/migrations/20231104172636_update_featureflags_use_float.exs

@@ -0,0 +1,7 @@
+defmodule Featureflagservice.Repo.Migrations.UpdateFeatureFlagsUseFloat do
+  use Ecto.Migration
+
+  def change do
+    "alter table featureflags alter enabled DROP DEFAULT,alter table featureflags alter enabled type numeric(2,1) using (case when enabled then 1.0 else 0.0 end), alter enabled set default '0.0';"
+  end
+end