Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: change most methods like set, update, expand, and collapse to sync, fixing #499 #524

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Feat: change most methods like set, update, expand, and collapse to sync, fixing #499 #524

merged 2 commits into from
Feb 21, 2025

Conversation

josdejong
Copy link
Owner

Fixes #499

  • Internally use flushSync instead of await tick() to ensure state and rendering is updated
  • Use flushSync directly after creating the editor via createJSONEditor, fixing initial expand all #499
  • Change methods set, update, patch, select, expand, collapse, acceptAutoRepair, focus, updateProps from asynchronous to to synchronous.

@josdejong josdejong merged commit 6dd69cd into main Feb 21, 2025
3 checks passed
@josdejong josdejong mentioned this pull request Feb 21, 2025
Closed
@josdejong josdejong deleted the feat/async-init branch February 21, 2025 13:19
josdejong added a commit that referenced this pull request Feb 21, 2025
@josdejong
feat: change most methods like set, update, and expand to synch…
e070163 
…ronous, fixing #499 (#524)

BREAKING CHANGE:
- most public methods changed from asynchronous to synchronous.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

initial expand all
1 participant
@josdejong